New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vars to theme slider #9065

Merged
merged 2 commits into from Jan 23, 2018

Conversation

Projects
None yet
2 participants
@mrgeorgegray
Contributor

mrgeorgegray commented Jan 22, 2018

  • Removes unused @slider-tooltip- vars
  • Moves and adds color vars for <Slider /> to default.less

  • Changes for master
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.
@codecov

This comment has been minimized.

codecov bot commented Jan 22, 2018

Codecov Report

Merging #9065 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9065   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files         195      195           
  Lines        4674     4674           
  Branches     1378     1378           
=======================================
  Hits         3985     3985           
  Misses        689      689

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb160a...56c1ca9. Read the comment docs.

// slider color
@slider-disabled-color: @disabled-color;
// tooltip
@slider-tooltip-color: #fff;

This comment has been minimized.

@afc163

afc163 Jan 23, 2018

Member

You shouldn't change the original var name which would cause a break change.

This comment has been minimized.

@mrgeorgegray

mrgeorgegray Jan 23, 2018

Contributor

Sorry, but I couldn't see that @slider-tooltip-color, @slider-tooltip-bg, @slider-tooltip-arrow-width, @slider-tooltip-distance and@slider-tooltip-arrow-color are being referenced anywhere so I thought it safe/good to remove them.

This comment has been minimized.

@afc163

afc163 Jan 23, 2018

Member

You are right, though @slider-margin is used before.

This comment has been minimized.

@mrgeorgegray

mrgeorgegray Jan 23, 2018

Contributor

Ahh yes, added it back in 56c1ca9

@afc163 afc163 merged commit 72a5b1f into ant-design:master Jan 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment