Fix(Table): Hide emptyType in `Table` when `loading` prop is true #9095
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9095 +/- ##
=======================================
Coverage 85.25% 85.25%
=======================================
Files 195 195
Lines 4674 4674
Branches 1378 1379 +1
=======================================
Hits 3985 3985
Misses 689 689
Continue to review full report at Codecov.
|
components/table/Table.tsx
Outdated
@@ -948,7 +949,7 @@ export default class Table<T> extends React.Component<TableProps<T>, TableState< | |||
className={classString} | |||
expandIconColumnIndex={expandIconColumnIndex} | |||
expandIconAsCell={expandIconAsCell} | |||
emptyText={locale.emptyText} | |||
emptyText={emptyText} |
nikogu
Jan 24, 2018
Contributor
const { ... loading ... } = this.props;
emptyText={loading && locale.emptyText}
const { ... loading ... } = this.props;
emptyText={loading && locale.emptyText}
sallen450
Jan 24, 2018
Author
Contributor
fixed
2 should be emptyText={!loading && locale.emptyText}
fixed
2 should be emptyText={!loading && locale.emptyText}
Merged
How to display images when the table content is empty? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for latest active branchfeature-x.x
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
fixed #9069