New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vars to theme Menu #9115

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
2 participants
@mrgeorgegray
Contributor

mrgeorgegray commented Jan 24, 2018

  • Adds vars for <Menu /> to default.less

  • Changes for master
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.
@codecov

This comment has been minimized.

codecov bot commented Jan 24, 2018

Codecov Report

Merging #9115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9115   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files         195      195           
  Lines        4677     4677           
  Branches     1379     1379           
=======================================
  Hits         3988     3988           
  Misses        689      689

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f3121...198bd15. Read the comment docs.

@nikogu nikogu merged commit 7d9a93e into ant-design:master Jan 25, 2018

4 checks passed

codecov/patch Coverage not affected when comparing b3f3121...198bd15
Details
codecov/project 85.26% remains the same compared to b3f3121
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment