New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifiction): Complement duration missing type definition. #9120

merged 1 commit into from Jan 25, 2018


None yet
2 participants

duhongjun commented Jan 25, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This comment has been minimized.


duhongjun commented Jan 25, 2018


This comment has been minimized.

codecov bot commented Jan 25, 2018

Codecov Report

Merging #9120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9120   +/-   ##
  Coverage   85.26%   85.26%           
  Files         195      195           
  Lines        4677     4677           
  Branches     1379     1379           
  Hits         3988     3988           
  Misses        689      689
Impacted Files Coverage Δ
components/notification/index.tsx 95.65% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9a93e...93ed138. Read the comment docs.

@yesmeck yesmeck merged commit 7c7125b into ant-design:master Jan 25, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 7d9a93e...93ed138
codecov/project 85.26% remains the same compared to 7d9a93e
continuous-integration/travis-ci/pr The Travis CI build passed
security/snyk No new issues

This comment has been minimized.


yesmeck commented Jan 25, 2018


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment