New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.tsx #9126

Merged
merged 5 commits into from Jan 26, 2018

Conversation

Projects
None yet
3 participants
@wanliyunyan
Contributor

wanliyunyan commented Jan 25, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

wanliyunyan added some commits Nov 22, 2017

Update index.tsx
add the “style” property for declare file
Merge remote-tracking branch 'upstream/master'
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@nikogu

This comment has been minimized.

Contributor

nikogu commented Jan 25, 2018

@wanliyunyan

This comment has been minimized.

Contributor

wanliyunyan commented Jan 25, 2018

@nikogu I do not understand how to modify, can you help me?

@nikogu

This comment has been minimized.

Contributor

nikogu commented Jan 25, 2018

@wanliyunyan please rebase master, the ci broken was be fixed already.

@codecov

This comment has been minimized.

codecov bot commented Jan 26, 2018

Codecov Report

Merging #9126 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9126      +/-   ##
==========================================
+ Coverage   85.26%   85.32%   +0.06%     
==========================================
  Files         195      195              
  Lines        4677     4683       +6     
  Branches     1379     1380       +1     
==========================================
+ Hits         3988     3996       +8     
+ Misses        689      687       -2
Impacted Files Coverage Δ
components/steps/index.tsx 100% <ø> (ø) ⬆️
components/date-picker/RangePicker.tsx 96.63% <0%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7125b...ff3a46a. Read the comment docs.

@nikogu nikogu merged commit e4d7e5e into ant-design:master Jan 26, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 7c7125b...ff3a46a
Details
codecov/project 85.32% (+0.06%) compared to 7c7125b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details
@afc163

This comment has been minimized.

Member

afc163 commented Jan 26, 2018

close #9119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment