New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Calendar value #9141

Merged
merged 1 commit into from Jan 26, 2018

Conversation

Projects
None yet
2 participants
@yesmeck
Member

yesmeck commented Jan 26, 2018

Fix #8885

If not control Calendar value, the internal value of Calendar will keep a different date than parent component.

@yesmeck yesmeck force-pushed the control-calendar-value branch from 8b35046 to 780f465 Jan 26, 2018

@yesmeck yesmeck changed the title from Control Calendar value, to Control Calendar value Jan 26, 2018

Control Calendar value, fix #8885
If not control Calendar value, the internal value of Calendar will keep a
different date than parent component.

@yesmeck yesmeck force-pushed the control-calendar-value branch from 780f465 to 3f7d5c3 Jan 26, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 26, 2018

Codecov Report

Merging #9141 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9141      +/-   ##
==========================================
+ Coverage   85.32%   85.39%   +0.06%     
==========================================
  Files         195      195              
  Lines        4683     4682       -1     
  Branches     1380     1380              
==========================================
+ Hits         3996     3998       +2     
+ Misses        687      684       -3
Impacted Files Coverage Δ
components/date-picker/createPicker.tsx 98.11% <ø> (+5.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e511c2a...3f7d5c3. Read the comment docs.

@nikogu nikogu merged commit 98387ad into master Jan 26, 2018

5 checks passed

codecov/patch Coverage not affected when comparing e511c2a...3f7d5c3
Details
codecov/project 85.39% (+0.06%) compared to e511c2a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details

@afc163 afc163 deleted the control-calendar-value branch Jan 27, 2018

yesmeck added a commit that referenced this pull request Jan 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment