New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复默认样式和card样式下,tabPosition=bottom时的样式错误 (#9104) #9165

Merged
merged 1 commit into from Feb 4, 2018

Conversation

Projects
None yet
4 participants
@ryanhoho
Contributor

ryanhoho commented Jan 29, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@codecov

This comment has been minimized.

codecov bot commented Jan 29, 2018

Codecov Report

Merging #9165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9165   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         193      193           
  Lines        4592     4592           
  Branches     1276     1276           
=======================================
  Hits         3925     3925           
  Misses        663      663           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a92772...45dafb9. Read the comment docs.

@yesmeck yesmeck merged commit 4235498 into ant-design:master Feb 4, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 4a92772...45dafb9
Details
codecov/project 85.47% remains the same compared to 4a92772
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details
@yesmeck

This comment has been minimized.

Member

yesmeck commented Feb 4, 2018

Thanks!

@afc163

This comment has been minimized.

Member

afc163 commented Feb 9, 2018

Fix #9104

@ryanhoho ryanhoho deleted the ryanhoho:bfix-9104 branch Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment