Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing forceRender prop for Collapse.Panel with rc-collapse. #9192

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

Pyroboomka
Copy link
Contributor

Finishing #8714 and should close #9178, since react-component/collapse#82 was merged.

First pull req, hope I did everything right.

@Pyroboomka Pyroboomka changed the title Syncing forceRender prop with rc-collapse. Syncing forceRender prop for Collapse.Panel with rc-collapse. Jan 30, 2018
@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #9192 into feature-3.2 will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           feature-3.2   #9192      +/-   ##
==============================================
+ Coverage        85.43%   85.5%   +0.06%     
==============================================
  Files              197     195       -2     
  Lines             4690    4600      -90     
  Branches          1387    1281     -106     
==============================================
- Hits              4007    3933      -74     
+ Misses             683     663      -20     
- Partials             0       4       +4
Impacted Files Coverage Δ
components/collapse/CollapsePanel.tsx 100% <ø> (ø) ⬆️
components/input-number/index.tsx 55.55% <0%> (-15.04%) ⬇️
components/transfer/operation.tsx 62.5% <0%> (-12.5%) ⬇️
components/tag/CheckableTag.tsx 70% <0%> (-8.95%) ⬇️
components/date-picker/createPicker.tsx 91.52% <0%> (-6.59%) ⬇️
components/slider/index.tsx 69.23% <0%> (-6.53%) ⬇️
components/upload/UploadList.tsx 84.81% <0%> (-6.1%) ⬇️
components/popconfirm/index.tsx 71.79% <0%> (-2.68%) ⬇️
components/affix/index.tsx 70.75% <0%> (-2.46%) ⬇️
components/calendar/Header.tsx 73.68% <0%> (-2.25%) ⬇️
... and 146 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad71ea...b197608. Read the comment docs.

@yesmeck
Copy link
Member

yesmeck commented Jan 31, 2018

Thanks @Pyroboomka

@yesmeck yesmeck merged commit 99469bd into ant-design:feature-3.2 Jan 31, 2018
@Pyroboomka Pyroboomka deleted the feature-3.2 branch February 4, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants