New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divider orientation feature #9275

Merged
merged 2 commits into from Feb 11, 2018

Conversation

Projects
None yet
2 participants
@jrvboesch
Contributor

jrvboesch commented Feb 6, 2018

User can align the text to the left or right with "orientation" prop, if not set it will be centered.

Juan and others added some commits Feb 3, 2018

Juan
Divider orientation feature
User can align the text to the left or right with "orientation" prop, if not set it will be centered.
Divider orientation feature
User can align the text to the left or right with "orientation" prop, if not set it will be centered.
@codecov

This comment has been minimized.

codecov bot commented Feb 6, 2018

Codecov Report

Merging #9275 into feature-3.3.0 will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##           feature-3.3.0    #9275      +/-   ##
=================================================
+ Coverage          85.85%   85.98%   +0.12%     
=================================================
  Files                195      195              
  Lines               4616     4715      +99     
  Branches            1284     1329      +45     
=================================================
+ Hits                3963     4054      +91     
- Misses               649      656       +7     
- Partials               4        5       +1
Impacted Files Coverage Δ
components/divider/index.tsx 100% <100%> (ø) ⬆️
components/calendar/index.tsx 84.88% <0%> (-5.44%) ⬇️
components/date-picker/createPicker.tsx 96.62% <0%> (-0.04%) ⬇️
components/date-picker/RangePicker.tsx 96.59% <0%> (+0.9%) ⬆️
components/dropdown/dropdown.tsx 96.55% <0%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c725cbe...4c67462. Read the comment docs.

@afc163 afc163 merged commit 0e591ef into ant-design:feature-3.3.0 Feb 11, 2018

4 checks passed

codecov/patch 100% of diff hit (target 85.85%)
Details
codecov/project 85.98% (+0.12%) compared to c725cbe
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details
@afc163

This comment has been minimized.

Member

afc163 commented Feb 11, 2018

Thx! Great job! @jrvboesch

image

yutingzhao1991 added a commit that referenced this pull request Mar 5, 2018

Divider orientation feature (#9275)
User can align the text to the left or right with "orientation" prop, if not set it will be centered.

zheeeng added a commit to zheeeng/ant-design that referenced this pull request Apr 12, 2018

Divider orientation feature (ant-design#9275)
User can align the text to the left or right with "orientation" prop, if not set it will be centered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment