New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper class on avatar when image doesnt exist #9278

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
2 participants
@andriijas
Contributor

andriijas commented Feb 6, 2018

When Avatar is rerendered because the image didnt exist, wrong class is applied today which makes the background transparent for Icon or text. This PR fixes that.

Thanks

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.
@codecov

This comment has been minimized.

codecov bot commented Feb 6, 2018

Codecov Report

Merging #9278 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9278      +/-   ##
==========================================
+ Coverage   85.85%   85.85%   +<.01%     
==========================================
  Files         195      195              
  Lines        4615     4616       +1     
  Branches     1283     1284       +1     
==========================================
+ Hits         3962     3963       +1     
  Misses        649      649              
  Partials        4        4
Impacted Files Coverage Δ
components/avatar/index.tsx 94.73% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b18b4...f372161. Read the comment docs.

@afc163 afc163 merged commit f1bd8d0 into ant-design:master Feb 7, 2018

4 checks passed

codecov/patch 100% of diff hit (target 85.85%)
Details
codecov/project 85.85% (+<.01%) compared to 59b18b4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment