proper class on avatar when image doesnt exist #9278
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9278 +/- ##
==========================================
+ Coverage 85.85% 85.85% +<.01%
==========================================
Files 195 195
Lines 4615 4616 +1
Branches 1283 1284 +1
==========================================
+ Hits 3962 3963 +1
Misses 649 649
Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When Avatar is rerendered because the image didnt exist, wrong class is applied today which makes the background transparent for Icon or text. This PR fixes that.
Thanks
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for latest active branchfeature-x.x
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :