New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type of column dataIndex #9298

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
2 participants
@clinyong
Contributor

clinyong commented Feb 7, 2018

This can check if key is in the object

interface User {
    name: string;
} 

const columns:  ColumnProps<User> = {
    dataIndex: "age" // compile error here, since age is not in the User
}
@codecov

This comment has been minimized.

codecov bot commented Feb 7, 2018

Codecov Report

Merging #9298 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9298   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files         195      195           
  Lines        4618     4618           
  Branches     1285     1285           
=======================================
  Hits         3965     3965           
  Misses        649      649           
  Partials        4        4
Impacted Files Coverage Δ
components/table/Table.tsx 93.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f29f0...2381f18. Read the comment docs.

@afc163 afc163 requested a review from yesmeck Feb 8, 2018

@yesmeck yesmeck merged commit f8e996e into ant-design:master Feb 8, 2018

4 checks passed

codecov/patch 100% of diff hit (target 85.85%)
Details
codecov/project 85.85% (+0%) compared to a5f29f0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details

yesmeck added a commit that referenced this pull request Feb 22, 2018

zheeeng added a commit to zheeeng/ant-design that referenced this pull request Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment