New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added selectionColumnWidth to TableRowSelection #9474

Merged
merged 3 commits into from Mar 5, 2018

Conversation

Projects
None yet
2 participants
@iannbing
Contributor

iannbing commented Mar 1, 2018

Fixes #8247
You can pass selectionColumnWidth in rowSelection to specify the width of the selection column.

@codecov

This comment has been minimized.

codecov bot commented Mar 1, 2018

Codecov Report

Merging #9474 into feature-3.3.0 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           feature-3.3.0    #9474      +/-   ##
=================================================
+ Coverage          85.91%   85.92%   +<.01%     
=================================================
  Files                195      195              
  Lines               4630     4631       +1     
  Branches            1287     1289       +2     
=================================================
+ Hits                3978     3979       +1     
  Misses               648      648              
  Partials               4        4
Impacted Files Coverage Δ
components/table/Table.tsx 93.21% <ø> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea95bf...f221f54. Read the comment docs.

@iannbing iannbing changed the title from Feature 3.3.0 to Added selectionColumnWidth to TableRowSelection Mar 1, 2018

@@ -145,6 +145,7 @@ Properties for row selection.
| getCheckboxProps | Get Checkbox or Radio props | Function(record) | - |
| hideDefaultSelections | Remove the default `Select All` and `Select Invert` selections | boolean | `false` |
| selectedRowKeys | Controlled selected row keys | string\[] | \[] |
| selectionColumnWidth | Set the width of the selection column | string\|number | - |

This comment has been minimized.

@afc163

afc163 Mar 2, 2018

Member

Just columnWidth is ok.

This comment has been minimized.

@iannbing

iannbing Mar 2, 2018

Contributor

Updated

@afc163 afc163 merged commit 9073237 into ant-design:feature-3.3.0 Mar 5, 2018

4 checks passed

codecov/patch Coverage not affected when comparing bea95bf...f221f54
Details
codecov/project 85.92% (+<.01%) compared to bea95bf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details

yutingzhao1991 added a commit that referenced this pull request Mar 5, 2018

Added selectionColumnWidth to TableRowSelection (#9474)
* Added selectionColumnWidth to TableRowSelection

* Updated documents

* Renamed selectionColumnWidth to columnWidth

zheeeng added a commit to zheeeng/ant-design that referenced this pull request Apr 12, 2018

Added selectionColumnWidth to TableRowSelection (ant-design#9474)
* Added selectionColumnWidth to TableRowSelection

* Updated documents

* Renamed selectionColumnWidth to columnWidth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment