New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add props of onPopupScroll in Select #9475

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
2 participants
@twobin
Contributor

twobin commented Mar 2, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@codecov

This comment has been minimized.

codecov bot commented Mar 2, 2018

Codecov Report

Merging #9475 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9475   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         195      195           
  Lines        4628     4628           
  Branches     1285     1285           
=======================================
  Hits         3976     3976           
  Misses        648      648           
  Partials        4        4
Impacted Files Coverage Δ
components/select/index.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24e418...02ca09e. Read the comment docs.

@afc163 afc163 merged commit d816879 into ant-design:master Mar 2, 2018

4 checks passed

codecov/patch Coverage not affected when comparing f24e418...02ca09e
Details
codecov/project 85.91% remains the same compared to f24e418
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details

zheeeng added a commit to zheeeng/ant-design that referenced this pull request Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment