fix tabs title font size #9509
Closed
fix tabs title font size #9509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Mar 4, 2018
| @tabs-title-font-size-lg: @font-size-sm; | ||
| @tabs-title-font-size-sm: @font-size-base; | ||
| @tabs-title-font-size-lg: @font-size-lg; | ||
| @tabs-title-font-size-sm: @font-size-sm; |
There was a problem hiding this comment.
This one should be @font-size-base
There was a problem hiding this comment.
would it make small tab have 14px font-size? as defined at top of this file:
@font-size-base : 14px;
@font-size-lg : @font-size-base + 2px;
@font-size-sm : 12px;
I thought small, default and large tab are 12px, 14px and 16px, respectively.
There was a problem hiding this comment.
Right, the font size of small tabs should be 14px.
afc163
pushed a commit
that referenced
this pull request
Mar 10, 2018
* Add the defaultActiveTabKey property for the Card component (close #8789, #8942) * `activeTabKey` should be added * Improve * Fix large tabs font size, close #9509 * docs: Add TreeSelect[dropdownClassName] * Fix passing dropdownClassName to tree-select * build: update remark-parse requirement to ^5.0.0 (#9545) Updates the requirements on [remark-parse](https://github.com/remarkjs/remark) to permit the latest version. - [Release notes](https://github.com/remarkjs/remark/releases) - [Commits](https://github.com/remarkjs/remark/commits/remark@5.0.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * add Tooltip contextMenu doc * Improve Grid and Layout type definition * fix: focus editor (#9548) * Fix test case for new jsdom (#9527) * Fix test case for new jsdom * use setTimeout as raf in jest jsdom * Fix cancelAnimationFrame * Add comment for jestjs/jest#5147 * longer timeout * fix snap * upgrade antd-tools * Update typescript requirement to ~2.7.2 (#9522) Updates the requirements on [typescript](https://github.com/Microsoft/TypeScript) to permit the latest version. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits/v2.7.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * Fix a ts error * build: update react-slick requirement to ~0.20.0 (#9543) Updates the requirements on [react-slick](https://github.com/akiran/react-slick) to permit the latest version. - [Changelog](https://github.com/akiran/react-slick/blob/master/CHANGELOG.md) - [Commits](https://github.com/akiran/react-slick/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Fix test cases * site: fix intersection-observer polyfill * docs: update recommendation * Fix typo WeexPickerProps -> WeekPickerProps (#9564) * use lodash * Fixed typo on Visualization rules (#9575) Style of a navigation should conform to the its level. should be Style of a navigation should conform to its level. * Improve Radio/Checkbox type definition Close #9574 * Remove AbstractCheckboxChangeEvent, fix TS4029 error See microsoft/TypeScript#9944 * Update index.en-US.md (#9579) * add transitionName from message.config (#9580) * add transitionName from message.config * Update index.en-US.md (#9579) * modify doc * build: update react-virtualized requirement to ~9.18.5 (#9544) Updates the requirements on [react-virtualized](https://github.com/bvaughn/react-virtualized) to permit the latest version. - [Changelog](https://github.com/bvaughn/react-virtualized/blob/master/CHANGELOG.md) - [Commits](https://github.com/bvaughn/react-virtualized/commits/9.18.5) Signed-off-by: dependabot[bot] <support@dependabot.com> * When treeNode is disabled, its switcher is highlight and clickabled (#9539) * When treeNode is disabled, its switcher is highlight and clickabled * rc-tree@1.7.11 * Fix moment require (#9528) Fix #9502 * Update snapshot
This was referenced Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :