Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed modal content overflowed #9592

Closed
wants to merge 1 commit into from
Closed

Conversation

Hughen
Copy link
Contributor

@Hughen Hughen commented Mar 9, 2018

The modal content will be overflowed, if the content is a long english word.
Just like this:

Modal.confirm({
  title: "Modal very long title:1:abcdefghijklmnopqrstuvwxyz:it:is:so:long:long:long:long:maybe:over:mask:view",
  content: "Modal content is very:long:long:long:long:abcdefghijklmnopqrstuvwxyz:string:filled:it:and:it:is:terrible",
  maskClosable: true,
});

I solved this problem by adding broken words

- fixed modal content overflowed, when the very long english
  word fill in Modal title
@codecov
Copy link

codecov bot commented Mar 9, 2018

Codecov Report

Merging #9592 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9592   +/-   ##
=======================================
  Coverage   85.81%   85.81%           
=======================================
  Files         195      195           
  Lines        4632     4632           
  Branches     1286     1286           
=======================================
  Hits         3975     3975           
  Misses        654      654           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4d294...a415a3a. Read the comment docs.

/>
);
expect(wrapper.render()).toMatchSnapshot();
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case is not useful to test work break situation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know what I should do for testing it, and I have offered a problem demo, ex:
Edit n3pk656j5p

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have tests for CSS right now.

@yesmeck
Copy link
Member

yesmeck commented Mar 30, 2018

Merged in 53abf88

@yesmeck yesmeck closed this Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants