New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu item clickable region #9666

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@dgeibi
Contributor

dgeibi commented Mar 14, 2018

水平菜单中菜单项内有链接,点击菜单项底部无效,因为绝对定位相对的是菜单项的 padding-box,但菜单项存在 2px 的 border-bottom

current

https://codesandbox.io/s/ko89m052vo

current

with fix

https://codesandbox.io/s/6j445q06n3

withfix

@codecov

This comment has been minimized.

codecov bot commented Mar 14, 2018

Codecov Report

Merging #9666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9666   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files         195      195           
  Lines        4689     4689           
  Branches     1310     1310           
=======================================
  Hits         4035     4035           
  Misses        651      651           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa97310...97b96d7. Read the comment docs.

@afc163 afc163 merged commit 6c77d33 into ant-design:master Mar 22, 2018

4 checks passed

codecov/patch Coverage not affected when comparing aa97310...97b96d7
Details
codecov/project 86.05% remains the same compared to aa97310
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details
@afc163

This comment has been minimized.

Member

afc163 commented Mar 22, 2018

Good job!~

zheeeng added a commit to zheeeng/ant-design that referenced this pull request Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment