Fixes LocaleProvider `moment` usage #9853
Merged
Conversation
@yesmeck Let me know if changes are needed. |
Codecov Report
@@ Coverage Diff @@
## master #9853 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 197 197
Lines 4713 4713
Branches 1315 1315
=======================================
Hits 4069 4069
Misses 641 641
Partials 3 3
Continue to review full report at Codecov.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In #9528 LocaleProvider was left untouched, and it also needs to make use of the
interopDefault
when invokingmoment
.Otherwise an error of
moment.locale is not a function
will be thrown.