New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes LocaleProvider `moment` usage #9853

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
2 participants
@klujanrosas
Contributor

klujanrosas commented Mar 28, 2018

In #9528 LocaleProvider was left untouched, and it also needs to make use of the interopDefault when invoking moment.

Otherwise an error of moment.locale is not a function will be thrown.

klujanrosas

@klujanrosas klujanrosas changed the title from Fixes locale provider moment usage to Fixes LocaleProvider moment usage Mar 28, 2018

@klujanrosas

This comment has been minimized.

Contributor

klujanrosas commented Mar 28, 2018

@yesmeck Let me know if changes are needed.

@klujanrosas klujanrosas changed the title from Fixes LocaleProvider moment usage to Fixes LocaleProvider `moment` usage Mar 28, 2018

@codecov

This comment has been minimized.

codecov bot commented Mar 28, 2018

Codecov Report

Merging #9853 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9853   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files         197      197           
  Lines        4713     4713           
  Branches     1315     1315           
=======================================
  Hits         4069     4069           
  Misses        641      641           
  Partials        3        3
Impacted Files Coverage Δ
components/locale-provider/index.tsx 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2a6c4...06a9a7f. Read the comment docs.

@yesmeck yesmeck merged commit d7b44bd into ant-design:master Mar 29, 2018

4 checks passed

codecov/patch 100% of diff hit (target 86.33%)
Details
codecov/project 86.33% (+0%) compared to 0d2a6c4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No dependency changes
Details
@yesmeck

This comment has been minimized.

Member

yesmeck commented Mar 29, 2018

Thanks!

zheeeng added a commit to zheeeng/ant-design that referenced this pull request Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment