Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes LocaleProvider `moment` usage #9853
Conversation
klujanrosas
changed the title from
Fixes locale provider moment usage
to
Fixes LocaleProvider moment usage
Mar 28, 2018
This comment has been minimized.
This comment has been minimized.
|
@yesmeck Let me know if changes are needed. |
klujanrosas
changed the title from
Fixes LocaleProvider moment usage
to
Fixes LocaleProvider `moment` usage
Mar 28, 2018
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Mar 28, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #9853 +/- ##
=======================================
Coverage 86.33% 86.33%
=======================================
Files 197 197
Lines 4713 4713
Branches 1315 1315
=======================================
Hits 4069 4069
Misses 641 641
Partials 3 3
Continue to review full report at Codecov.
|
yesmeck
merged commit d7b44bd
into
ant-design:master
Mar 29, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
added a commit
to zheeeng/ant-design
that referenced
this pull request
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
klujanrosas commentedMar 28, 2018
•
edited
In #9528 LocaleProvider was left untouched, and it also needs to make use of the
interopDefaultwhen invokingmoment.Otherwise an error of
moment.locale is not a functionwill be thrown.