Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typescript definition and add table props onHeaderRow #9902

merged 1 commit into from Apr 2, 2018


Copy link

@Nokecy Nokecy commented Apr 2, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@Nokecy Nokecy changed the title add table props onHeaderRow add typescript type table props onHeaderRow Apr 2, 2018
@Nokecy Nokecy changed the title add typescript type table props onHeaderRow Fixed typescript definition and add table props onHeaderRow Apr 2, 2018
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #9902 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9902   +/-   ##
  Coverage   86.27%   86.27%           
  Files         197      197           
  Lines        4721     4721           
  Branches     1316     1316           
  Hits         4073     4073           
  Misses        645      645           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2807d75...d3c2aac. Read the comment docs.

@yesmeck yesmeck merged commit 98d56b2 into ant-design:master Apr 2, 2018
@Nokecy Nokecy deleted the patch-1 branch April 2, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants