Fix image url display with non-image extention in Upload #9936
Conversation
|
Deploy preview for stupefied-hodgkin-56a61d ready! Built with commit d9fe8ca https://deploy-preview-9936--stupefied-hodgkin-56a61d.netlify.com |
|
Awesome deploy preview! |
now we treat url following below rules: 1. `data:image..` => image 2. `http://xxx.com/xxxx.(webp|svg|png|gif|jpg|jpeg)` => image 3. `http://xxx.com/xxx.zip` other extensions => non-image 4. `data:application..` other minetypes in base64 text => non-image 5. `http://xxx.com/xxx` without any extensions => image close #9835 close #9681 ref #9621
|
@yesmeck Is the |
|
Yes, netlify will send notification if deploy fails. |
Codecov Report
@@ Coverage Diff @@
## master #9936 +/- ##
==========================================
+ Coverage 86.27% 86.29% +0.01%
==========================================
Files 197 197
Lines 4722 4734 +12
Branches 1316 1320 +4
==========================================
+ Hits 4074 4085 +11
- Misses 645 646 +1
Partials 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Improve the image-judgement behavior in #9621 cc @zswang .
Now we need to use
file.isNotImageto indicate the non-image files in uploadList.close #9835
close #9681