Add collapse styles to default.less #9943
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
This pushes color and padding for the Collapse component into defaults so they can easily be overridden.
I set up the values such that the Collapse will not change appearances for anyone currently using the defaults (or any values those defaults were using), but allows a user to remove all of the padding from both the header and the content of a Collapse.
Properties added to
I couldn't see any tests around default styles for any of the other components, but if these changes are testable I'll be happy to go back and add them.
I don't think this requires any updates to documentation.
@@ Coverage Diff @@ ## feature-3.5.0 #9943 +/- ## ============================================== Coverage 86.28% 86.28% ============================================== Files 197 197 Lines 4740 4740 Branches 1321 1321 ============================================== Hits 4090 4090 Misses 647 647 Partials 3 3
How about this suggestion?
It's a little weird, because the
The collapse/show animation doesn't work right without the padding set up across the two elements like this. From an end-user point of view, I think this is the easiest thing.
…ping var name the same because the end user doesn't need to know the difference