$frame is undefined in CallRerouting::connectDefaultInternals #50

Closed
maartenscholz opened this Issue Mar 22, 2017 · 8 comments

Comments

Projects
None yet
2 participants
@maartenscholz

maartenscholz commented Mar 22, 2017

When mocking an class with Prophecy which has a @link annotation (which are read by phpdocumenter which does a call_user_func_array which patchwork intercepts) It gets into a path in patchwork which passes through CallRerouting::connectDefaultInternals. In connectDefaultInternals there is a $frame variable which is never set. This causes my test to fail Undefined variable: frame. I would fix it myself but I don't have enough knowledge of the internals of patchwork.

Using version 2.0.1

@antecedent antecedent reopened this Mar 22, 2017

@antecedent

This comment has been minimized.

Show comment
Hide comment
@antecedent

antecedent Mar 22, 2017

Owner

Does version 2.0.2 solve the issue?

Owner

antecedent commented Mar 22, 2017

Does version 2.0.2 solve the issue?

@maartenscholz

This comment has been minimized.

Show comment
Hide comment
@maartenscholz

maartenscholz Mar 22, 2017

The frame error is fixed but now I'm getting Undefined index: class

maartenscholz commented Mar 22, 2017

The frame error is fixed but now I'm getting Undefined index: class

@antecedent

This comment has been minimized.

Show comment
Hide comment
@antecedent

antecedent Mar 22, 2017

Owner

I'm sorry; this is taking longer to fix than I had expected. I'll still try to have it ready by tonight (UTC), though.

Owner

antecedent commented Mar 22, 2017

I'm sorry; this is taking longer to fix than I had expected. I'll still try to have it ready by tonight (UTC), though.

antecedent added a commit that referenced this issue Mar 22, 2017

Another attempt at fixing #50
Commented the method, too.
@maartenscholz

This comment has been minimized.

Show comment
Hide comment
@maartenscholz

maartenscholz Mar 22, 2017

No worries, thanks for already looking into it!

No worries, thanks for already looking into it!

@antecedent

This comment has been minimized.

Show comment
Hide comment
@antecedent

antecedent Mar 22, 2017

Owner

Could you check if the latest commit to master fixes this?

Owner

antecedent commented Mar 22, 2017

Could you check if the latest commit to master fixes this?

@maartenscholz

This comment has been minimized.

Show comment
Hide comment
@maartenscholz

maartenscholz Mar 23, 2017

When using master tests are passing!

maartenscholz commented Mar 23, 2017

When using master tests are passing!

antecedent added a commit that referenced this issue Mar 23, 2017

@antecedent

This comment has been minimized.

Show comment
Hide comment
@antecedent

antecedent Mar 23, 2017

Owner

Glad to hear that :) I've tagged it as 2.0.3 now.

Owner

antecedent commented Mar 23, 2017

Glad to hear that :) I've tagged it as 2.0.3 now.

@maartenscholz

This comment has been minimized.

Show comment
Hide comment
@maartenscholz

maartenscholz Mar 23, 2017

We are back on 2.0.3 and everything is working fine. Thanks a lot for the quick response/fix!

We are back on 2.0.3 and everything is working fine. Thanks a lot for the quick response/fix!

@antecedent antecedent closed this Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment