New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patchwork\Preprocessor\Stream->rmdir: rmdir() expects parameter 2 to be resource, integer given #7

Closed
PatchRanger opened this Issue May 29, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@PatchRanger

PatchRanger commented May 29, 2013

I am using your project as a library for Drupal module called "Module Object Oriented Programming API" (http://drupal.org/project/moopapi).
Current code is placed in GitHub project: http://github.com/PatchRanger/drupal7-moopapi .
Though patchwork works (I am able to redefine functions), my tests are producing multiple warnings with such text: "rmdir() expects parameter 2 to be resource, integer given". See log of build at Travis: https://travis-ci.org/PatchRanger/drupal7-moopapi/builds/7588558#L259.

@antecedent

This comment has been minimized.

Show comment
Hide comment
@antecedent

antecedent May 30, 2013

Owner

Fixed!

However, I'm kind of worried about this module of yours. Patchwork is slow – hopefully not too slow for testing and development, but when it comes to production, the overhead is in most cases going to be an issue. I'm not going to try and talk you out of this decision, but I certainly want to make sure you're fully informed about the potential issues. I'd also suggest profiling the module (when it's done) on a test application yourself and seeing how much of an issue it actually is in practice.

Owner

antecedent commented May 30, 2013

Fixed!

However, I'm kind of worried about this module of yours. Patchwork is slow – hopefully not too slow for testing and development, but when it comes to production, the overhead is in most cases going to be an issue. I'm not going to try and talk you out of this decision, but I certainly want to make sure you're fully informed about the potential issues. I'd also suggest profiling the module (when it's done) on a test application yourself and seeing how much of an issue it actually is in practice.

@antecedent antecedent closed this May 30, 2013

@PatchRanger

This comment has been minimized.

Show comment
Hide comment
@PatchRanger

PatchRanger May 30, 2013

Wow, thank you for ultimate agility!
Thanks for warning as well. Aforementioned module is a tool for developers - so no reason to worry. It is going to be used as a way to provide development flexibility, thus its slowness (if any) is not an issue at all.
Thanks a lot once more for quick fix.

May I ask you: what kind of projects do you use Patchwork for?

PatchRanger commented May 30, 2013

Wow, thank you for ultimate agility!
Thanks for warning as well. Aforementioned module is a tool for developers - so no reason to worry. It is going to be used as a way to provide development flexibility, thus its slowness (if any) is not an issue at all.
Thanks a lot once more for quick fix.

May I ask you: what kind of projects do you use Patchwork for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment