Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong popup positioning #3

Closed
AleCaste opened this issue Feb 4, 2017 · 3 comments

Comments

@AleCaste
Copy link

commented Feb 4, 2017

I have a complex webpage layout and the popup positioning calculations of the plugin (excellent plugin by the way!) are wrong.
I replaced the line in circle-picker.js that says...
var parentPosition = _parent.position(), parentWidth = _parent.outerWidth(), parentHeight = _parent.outerHeight(),
... with...
var parentPosition = _parent.offset(), parentWidth = _parent.outerWidth(), parentHeight = _parent.outerHeight(),
... and now the popup positioning is working fine for me.
Could you have a look at this?
Thanks!
Alex

@antelle

This comment has been minimized.

Copy link
Owner

commented Feb 4, 2017

Sure, it must be offset, to be able to work with absolute positioning. Fixing it now...

@antelle antelle closed this in 9ccf584 Feb 4, 2017
@antelle

This comment has been minimized.

Copy link
Owner

commented Feb 4, 2017

done, v1.3.0
thanks for that 👍

@AleCaste

This comment has been minimized.

Copy link
Author

commented Feb 4, 2017

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.