fix: pass config.includePastSponsors to partitionTiers
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v0.9.0 did not show GitHub's Past Sponsors.
#58 introduce
includePastSponsorsargument forpartitionTiersfunction, but It looks like that forgot to passconfig.includePastSponsors.As a result, past sponsors always to be hidden.
https://github.com/antfu/sponsorkit/blob/35f29eca827894b6f9e89d99bcf5b70bed358ec4/src/config.ts#L120-L136
Linked Issues
None
Additional context
Run
npm run buildinexample/with following env.This example includes past sponsors.
In v0.9.0:
In this PR: