Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in reading GAMS parameters #26

Merged
merged 2 commits into from Jan 13, 2020

Conversation

@FrankErrickson
Copy link
Contributor

FrankErrickson commented Jan 13, 2020

Two lines had errors when trying to read in GAMS parameters. This hard codes the damadj term (not used in GAMS) to 1 and adds the eqmat term to the parameter excel file.

Two lines had errors when trying to read in GAMS parameters. This hard codes the `damadj` term (not used in GAMS) to 1 and adds the `eqmat` term to the parameter excel file.
Copy link
Contributor

davidanthoff left a comment

Great!

I'm a bit surprised we didn't catch this earlier. Don't we have some tests that would have failed previously? Or do we only have tests for the Excel version?

@davidanthoff davidanthoff merged commit d340916 into anthofflab:master Jan 13, 2020
10 checks passed
10 checks passed
test (1.2.0, x64, ubuntu-latest)
Details
test (1.2.0, x64, windows-latest)
Details
test (1.2.0, x64, macOS-latest)
Details
test (1.2.0, x86, ubuntu-latest)
Details
test (1.2.0, x86, windows-latest)
Details
test (1.0.5, x64, ubuntu-latest)
Details
test (1.0.5, x64, windows-latest)
Details
test (1.0.5, x64, macOS-latest)
Details
test (1.0.5, x86, ubuntu-latest)
Details
test (1.0.5, x86, windows-latest)
Details
@lrennels

This comment has been minimized.

Copy link
Contributor

lrennels commented Jan 13, 2020

I think we must only have tests for the Excel version, thanks @FrankErrickson I was about to work on fixing this myself!

@FrankErrickson FrankErrickson deleted the FrankErrickson:fix_gams branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.