New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hook for sqlite3 on Win and improvement for win32file hook #261

Merged
merged 1 commit into from May 20, 2017

Conversation

Projects
None yet
3 participants
@Nutznieser
Contributor

Nutznieser commented Apr 26, 2017

See issue #207 and #212 ...

finder.IncludeModule("pywintypes")
finder.IncludeModule("win32timezone")

This comment has been minimized.

@anthony-tuininga

anthony-tuininga May 14, 2017

Owner

This change is not needed as far as I can tell. I just tried with a new installation of Python 3.6 and it works just fine without win32timezone. Do you have an example that demonstrates the need?

This comment has been minimized.

@Nutznieser

Nutznieser May 16, 2017

Contributor

Here is an example for you :-)
I modified minor things of the wxPython example supplied with the cx_freeze package. You can compare these for seeing the difference.

If you run the setup.py for this example you will first see the error described in issue #254. If you patch cx_freeze with the pull request #260, the script runs perfect.

After freezing, start the executable and press the button "Push me". Now you will get the error described in the issue #212 => ModuleNotFoundError: No module named 'win32timezone'

My environment: Win 7/10 64Bit, Python 3.6.1, pywin32 and wxPython 4.0.0a1.
Attached example: cx_freeze-bug_test.zip

This comment has been minimized.

@anthony-tuininga

anthony-tuininga May 20, 2017

Owner

Got it. Thanks!

be present in the build directory."""
if sys.platform == "win32":
dll_name = "sqlite3.dll"
dll_path = os.path.join(sys.base_prefix, "DLLs", dll_name)

This comment has been minimized.

@dandersson

dandersson May 22, 2017

sys.base_prefix breaks on Python 2.7, since sys.base_prefix is only present in Python 3.3+ (see docs). In older Python installations, one should look for sys.real_prefix which is set by virtualenv within virtual environments, and fall back to sys.prefix which is always set (but does not point to the system installation if run from a virtual environment).

See pull request #272.

@Nutznieser Nutznieser deleted the Nutznieser:patch-2 branch Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment