Do not create version resource when version is omitted #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously an AttributeError would be thrown when the version was not specified.
|
I updated this to avoid creating a version resource when the version number is omitted. |
rcutmore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously an
AttributeErrorwould be thrown during the freeze process when pywin32 was installed and the version was not specified. This change avoids throwing an error by just specifying a default version of "0.0.0.0" if needed. If we would rather not specify a default version it would be nice to throw aConfigErrorthat indicates the version is missing instead.This fixes #154. I searched and couldn't find any other posted issues related to this.
Edit: It might be better to just return early in
_AddVersionResourceif the version is missing. Either way I'm happy to revise this PR for any changes.