New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create version resource when version is omitted #279

Merged
merged 2 commits into from Aug 6, 2017

Conversation

Projects
None yet
2 participants
@rcutmore
Contributor

rcutmore commented Jun 28, 2017

Previously an AttributeError would be thrown during the freeze process when pywin32 was installed and the version was not specified. This change avoids throwing an error by just specifying a default version of "0.0.0.0" if needed. If we would rather not specify a default version it would be nice to throw a ConfigError that indicates the version is missing instead.

This fixes #154. I searched and couldn't find any other posted issues related to this.

Edit: It might be better to just return early in _AddVersionResource if the version is missing. Either way I'm happy to revise this PR for any changes.

rcutmore added some commits Jun 28, 2017

Use default version when not specified
Previously an AttributeError would be thrown when the version was not
specified.
@rcutmore

This comment has been minimized.

Contributor

rcutmore commented Jul 5, 2017

I updated this to avoid creating a version resource when the version number is omitted.

@rcutmore rcutmore changed the title from Use default version when not specified to Do not create version resource when version is omitted Jul 5, 2017

@anthony-tuininga anthony-tuininga merged commit 5e7ad73 into anthony-tuininga:master Aug 6, 2017

@rcutmore rcutmore deleted the rcutmore:missing-version branch Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment