Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable (partially) to work under non-ASCII path on Windows. #483

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@Suzumizaki
Copy link

commented Jul 12, 2019

Consider building under virtual environments made by venv which contains non-ASCII characters.

Especially, the default user name often contains that characters under non-English mode Windows. That means the full path of "Documents" or "Desktop" etc. possibly be contain such characters.

In fact, due to using imagehlp.h functions, this is partial solution. For example, under en-US environment, this patch affects nothing. Another example, when using Japanese mode Windows and using characters that is not included cp932, this patch would help none.

But this patch would much better user experience, because at least they can use their native characters.

Enable (partially) to work under non-ASCII path on Windows.
Consider building under virtual environments made by venv which contains non-ASCII characters.

Especially, the default user name often contains that characters under non-English mode Windows. That means the full path of "Documents" or "Desktop" etc. possibly  be contain such characters.

In fact, due to using imagehlp.h functions, this is partial solution. For example, under en-US environment, this patch affects nothing. Another example, when using Japanese mode Windows and using characters that is *not* included cp932, this patch would help none.

But this patch would much better user experience, because at least they can use their native characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.