Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upChanges to extractCMYKChannel with accompanying example and docs. #8
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks so much for the kind words - we're really glad you're liking the library and using it!! And, thanks for this wonderful addition. I wasn't familiar with the technique and now really excited to try it out. Do you have any example prints using CMYK compression? If so, we could add one to the documentation page. Thanks again! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
amazing - thanks! Just added it to the docs page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
robinsloan commentedSep 24, 2019
Hi there! First, as preamble: p5.riso is amazing---totally ingenious, instantly useful. I've already run images generated with this library through my trusty Risograph here in Berkeley.
There's a CMYK channel manipulation technique I learned from Riso wizard Max Stadnik that I've found myself using a ton. Looking at the code for p5.riso, I realized it wouldn't be too difficult to implement… so, I did!
With the Riso, you're often going from a four-channel CMYK image to a two-color Riso print, and it can sometimes---not always, but sometimes!---be useful to "compress" two CMYK channels into each Riso color layer. The results are sometimes more "natural" looking, because you're discarding less color information. The results can also be super weird! Either way, it's just a nice option to have.
The example I've included in this pull request is probably a more eloquent explanation than this.
Thanks again for a great library!