New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating config for circleci too #4

Merged
merged 42 commits into from Jan 6, 2019

Conversation

1 participant
@antifuchs
Copy link
Owner

antifuchs commented Jan 5, 2019

Since I got a bit unhappy at travis, let's try running this on circle now. Seems like a far faster alternative that is much easier to configure.

antifuchs added some commits Jan 5, 2019

Be generic across CI systems
This extracts travis's template into a module via traits, and should
hopefully let me do the same thing for gitlab CI.
Bah
*facepalm* remove the rust-toolchain file ):
THAT'S WHY I COULDN'T RUN TESTS ON STABLE
No longer support allow_failure
It's not a great thing to have in a build (slows it down
unnecessarily, because if it was meaningful you'd just drop the build
tasks), and isn't really supported on circle.
Honor the commandline and install_commandline
A field for this existed, but it was never hooked up! Now, we pass
that value through all the way from Cargo.toml to all the config
files.
@antifuchs

This comment has been minimized.

Copy link
Owner

antifuchs commented Jan 5, 2019

bors try

bors bot added a commit that referenced this pull request Jan 5, 2019

antifuchs added some commits Jan 6, 2019

Get rid of the ugly prereq hack
...instead, generate the filters from config (or hardcode them for
now), then interpolate them as JSON.
@antifuchs

This comment has been minimized.

Copy link
Owner

antifuchs commented Jan 6, 2019

bors try

bors bot added a commit that referenced this pull request Jan 6, 2019

@antifuchs

This comment has been minimized.

Copy link
Owner

antifuchs commented Jan 6, 2019

bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 6, 2019

try

Not awaiting review

antifuchs added some commits Jan 6, 2019

UGH ANOTHER TYPO
validate your config files, people
Rename the workflow, apply to all non-.tmp branches
This should allow PR authors to see what their PR would look
like, and still allow bors to correctly work.
Define an overall success task
This should depend on the remaining tasks (that require success), and
allow bors to check the status of that commit. Welp.
Update bors config for the correct commit status
the workflow status isn't a github status but a github *check*.
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 6, 2019

try

Build succeeded

  • build_and_test
@antifuchs

This comment has been minimized.

Copy link
Owner

antifuchs commented Jan 6, 2019

bors try

bors bot added a commit that referenced this pull request Jan 6, 2019

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 6, 2019

try

Build succeeded

@antifuchs

This comment has been minimized.

Copy link
Owner

antifuchs commented Jan 6, 2019

bors try

bors bot added a commit that referenced this pull request Jan 6, 2019

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 6, 2019

try

Build succeeded

@antifuchs

This comment has been minimized.

Copy link
Owner

antifuchs commented Jan 6, 2019

bors r+

bors bot added a commit that referenced this pull request Jan 6, 2019

Merge #4
4: Allow generating config for circleci too r=antifuchs a=antifuchs

Since I got a bit unhappy at travis, let's try running this on circle now. Seems like a far faster alternative that is much easier to configure.

Co-authored-by: Andreas Fuchs <asf@boinkor.net>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 6, 2019

Build succeeded

@bors bors bot merged commit aec9499 into master Jan 6, 2019

7 checks passed

bors Build succeeded
Details
ci/circleci: ci_success Your tests passed on CircleCI!
Details
ci/circleci: clippy Your tests passed on CircleCI!
Details
ci/circleci: rustfmt Your tests passed on CircleCI!
Details
ci/circleci: test-nightly Your tests passed on CircleCI!
Details
ci/circleci: test-stable Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@antifuchs antifuchs deleted the generic-ci-systems branch Jan 6, 2019

@antifuchs antifuchs referenced this pull request Jan 6, 2019

Closed

Enable bors #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment