New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more Cargo.toml scenarios #5

Merged
merged 3 commits into from Jan 6, 2019

Conversation

1 participant
@antifuchs
Copy link
Owner

antifuchs commented Jan 6, 2019

This PR fixes #1 and restructures main.rs a bit to be more readable
(and to have better error handling).

@antifuchs antifuchs force-pushed the empty-cargo-toml branch from 2e1b59a to b8da968 Jan 6, 2019

antifuchs added some commits Jan 6, 2019

Get rid of tons of borrowing/ownership issues
Since the TemplateCIConfig structure had borrowed fields on it (to
make usage with askama easier), we couldn't conveniently parse the
metadata format and had a bug.

* Restructure TemplateCIConfig and build matrix entries to only have
  owned data on them.

* Catch a case where the cargo package metadata is null & return the
  default config for that case.

@antifuchs antifuchs force-pushed the empty-cargo-toml branch from b8da968 to a029234 Jan 6, 2019

@antifuchs

This comment has been minimized.

Copy link
Owner

antifuchs commented Jan 6, 2019

bors r+

bors bot added a commit that referenced this pull request Jan 6, 2019

Merge #5
5: Handle more Cargo.toml scenarios r=antifuchs a=antifuchs

This PR fixes #1 and restructures main.rs a bit to be more readable
(and to have better error handling).

Co-authored-by: Andreas Fuchs <asf@boinkor.net>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 6, 2019

Build succeeded

@bors bors bot merged commit 5551ae9 into master Jan 6, 2019

6 checks passed

bors Build succeeded
Details
ci/circleci: ci_success Your tests passed on CircleCI!
Details
ci/circleci: clippy Your tests passed on CircleCI!
Details
ci/circleci: rustfmt Your tests passed on CircleCI!
Details
ci/circleci: test-nightly Your tests passed on CircleCI!
Details
ci/circleci: test-stable Your tests passed on CircleCI!
Details

@antifuchs antifuchs deleted the empty-cargo-toml branch Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment