Permalink
Commits on Oct 21, 2018
  1. Merge pull request #27 from antifuchs/refactor-chaining

    antifuchs committed Oct 21, 2018
    Update filter chaining to be more consistent
Commits on Oct 14, 2018
  1. Add an API docs badge

    antifuchs committed Oct 14, 2018
  2. Update gemfile for nokogiri vuln

    antifuchs committed Oct 14, 2018
  3. Fix the first code example in the README

    antifuchs committed Oct 14, 2018
    ...it didn't mention the some-side-project label. Oops.
    
    Fixes #20, thanks @aspiers!
  4. Negatively chain the has_attachment criteria

    antifuchs committed Oct 14, 2018
  5. Correctly handle boolean criteria (i.e. has_attachment)

    antifuchs committed Oct 14, 2018
    Only emit the criteria if it was set in the filter body, and if set to
    false, *do* emit it.
  6. Refactor filter chaining to merge all criteria

    antifuchs committed Oct 14, 2018
    With this change, it should be possible to fully support chained
    filters that exercise any of the possible criteria gmail
    allows.
    
    There's a tiny fix in here (Fixes #11), which makes the chain merge
    code automatically upconvert literals into arrays when they're not
    arrays yet.
  7. Default subject criteria to the empty array

    antifuchs committed Oct 14, 2018
    ...much like we did with all the other criteria that can hold arrays.
  8. Define criteria in filters differently

    antifuchs committed Oct 14, 2018
    This will allow us to merge them in a far nicer way down the line - by
    checking #criteria, instead of ad-hoc pulling only the ones that I
    remembered at the time.
    
    Also, restructure the docs a bit so that criteria come first, followed
    by actions.
  9. Include ourselves in the Gemfile

    antifuchs committed Oct 14, 2018
    This makes it easier to run tests, so pretty clearly worth it.
  10. In recursive filters, group criteria containing spaces

    antifuchs committed Oct 14, 2018
    The way we emitted "has" filters that contained spaces was broken if
    they were nested, especially in ":or" clauses; there, gmail would
    interpret the space as the end of the nested filter's criteria.
    
    For readability's sake, gmail-britta only groups nested filters when
    they actually contain a space.
    
    Fixes #25.
  11. Remove codeclimate badge (fixes #26)

    antifuchs committed Oct 14, 2018