Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize number formatting #11

Closed
vsubhuman opened this issue May 28, 2018 · 2 comments
Closed

Localize number formatting #11

vsubhuman opened this issue May 28, 2018 · 2 comments
Assignees
Milestone

Comments

@vsubhuman
Copy link
Member

@vsubhuman vsubhuman commented May 28, 2018

See this comment and following explanation: #2 (comment)

For now - there's en-US locale hardcoded here. We need to try and get current locale from browser to format number for different languages properly.

Might be some complications with cleave used to format numbers in input fields. But I hope it's configurable enough to let me specify order-separator and decimal-separator characters manually. Not sure how user input will be processed then (pressing dot to separate decimal places and pressing local separator key for the same purpose), need to test it out and maybe add some hacks.


Wiki: https://github.com/antipalos/antipalos.github.io/wiki/Cardano-Calculator:-Localized-number-formatting

@vsubhuman vsubhuman self-assigned this May 28, 2018
@vsubhuman
Copy link
Member Author

@vsubhuman vsubhuman commented May 28, 2018

@gufmar, watch out for this issue :)

Loading

@vsubhuman vsubhuman added this to To do in Cardano-calculator May 28, 2018
@vsubhuman vsubhuman added this to the v0.1.1 milestone May 31, 2018
@vsubhuman vsubhuman moved this from To do to In progress in Cardano-calculator Jun 15, 2018
@vsubhuman vsubhuman mentioned this issue Jun 15, 2018
4 tasks
@vsubhuman vsubhuman mentioned this issue Jun 16, 2018
vsubhuman added a commit that referenced this issue Jun 19, 2018
@vsubhuman
Copy link
Member Author

@vsubhuman vsubhuman commented Jun 19, 2018

Read detailed description of how this feature now works here: #19 (comment)

Loading

@vsubhuman vsubhuman closed this Jun 19, 2018
@vsubhuman vsubhuman moved this from In progress to Done in Cardano-calculator Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant