Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Layout #8

Closed
wants to merge 9 commits into from

Conversation

@DEFAULTERROR1
Copy link
Collaborator

commented May 26, 2018

Restructured the base, added cleave.js and bootstrap as yarn packages, also updated the html markup to make use of the bootstrap framework, which gives now a good responsive foundation and fixes the points mentioned in #6

@vantuz-subhuman

This comment has been minimized.

Copy link
Member

commented May 26, 2018

O_O This is one fucking Christmas giveaway! Thanks, @DEFAULTERROR1, I can't even stress enough how much I appreciate all of this!!! I hope to review the whole thing this weekend ASAP and merge this beauty :)

This is awesome!

@vantuz-subhuman

This comment has been minimized.

Copy link
Member

commented May 26, 2018

@DEFAULTERROR1, can you please open new PR into the new branch #6-Mobile-layout - I've just created it. I really want to merge it, but I don't want it to go directly into master yet, so I could combine with some additional fixes I was planning and merge them all together into v1.1

I REALLY like the whole thing! This is awesome contribution, thank you very much. The only two concerns I got are:

  1. The icons in the PR are (as I managed to google) from these guys - h5bp.github.io. I don't know if they would mind us using these icons, and I don't really know maybe you're one of them :) I would actually really like to use the official $ADA logos like this one, but I couldn't find proper sources for those, yet. Of course I wouldn't bother you with this additionally, so I will gladly merge it as it is and then maybe try to work icons out.

  2. The only real concern to me is that the calculator page is now requires a lot of scrolling even on desktop (screenshot). Original page (however horrible) - allowed the whole thing to be visible on one screen (screenshot), so users can change parameters and watch the results change right there without the need to scroll. I understand, that on the mobile - there's not other solution, but for the desktop I would really like for results to be visible. But again! I will gladly merge as it is to not bother you anymore with this and then just play around to see if there's anything possible without breaking the beauty, tho.

For the second point I am thinking of other possible solutions, and would be glad to any proposals :) Like, I'm thinking that maybe having a small fixed results panel at the bottom could help to solve the issue. So users would scroll thru parameters but always see the results changing right there. Just throwing around some possible options for me to check out :)

@vantuz-subhuman vantuz-subhuman self-requested a review May 26, 2018

@DEFAULTERROR1

This comment has been minimized.

Copy link
Collaborator Author

commented May 27, 2018

@vantuz-subhuman i will create a PR to the new branch.

I also got some additonal further ideas, i will test out today or tommorrow:

  1. I forgot to add the license, we can use the icons freely if we give License and Copyright notice (MIT-License), but since those are ugly and meant to be placeholders i could also just use blank placeholder images until Cardano Foundation has figured out their license.

  2. For mobile i have an idea for a swiper. Basically that you can swipe the different parameter groups (user, environment parameters etc) left and right. This would save enormous space. For the medium sized and desktop version i'll have to play around with reducing the default font-sizes, paddings and margins to save some space.

@vantuz-subhuman

This comment has been minimized.

Copy link
Member

commented May 27, 2018

@DEFAULTERROR1

but since those are ugly and meant to be placeholders i could also just use blank placeholder images

Nah, I think those are funny :) So if we can legally - I'm all for using them while figuring out normal
ADA icons

For mobile i have an idea for a swiper

That would be extremely awesome! I thought initially about how cool that would be, but I can't even remotely imagine how this stuff is done :)

I also got some additonal further ideas

Thank you again for continuing with this awesome contribution!!

@vantuz-subhuman

This comment has been minimized.

Copy link
Member

commented May 31, 2018

This is moved and merged in: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.