-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Layout #8
Conversation
O_O This is one fucking Christmas giveaway! Thanks, @DEFAULTERROR1, I can't even stress enough how much I appreciate all of this!!! I hope to review the whole thing this weekend ASAP and merge this beauty :) This is awesome! |
@DEFAULTERROR1, can you please open new PR into the new branch I REALLY like the whole thing! This is awesome contribution, thank you very much. The only two concerns I got are:
For the second point I am thinking of other possible solutions, and would be glad to any proposals :) Like, I'm thinking that maybe having a small fixed results panel at the bottom could help to solve the issue. So users would scroll thru parameters but always see the results changing right there. Just throwing around some possible options for me to check out :) |
@vantuz-subhuman i will create a PR to the new branch. I also got some additonal further ideas, i will test out today or tommorrow:
|
Nah, I think those are funny :) So if we can legally - I'm all for using them while figuring out normal
That would be extremely awesome! I thought initially about how cool that would be, but I can't even remotely imagine how this stuff is done :)
Thank you again for continuing with this awesome contribution!! |
This is moved and merged in: #10 |
Restructured the base, added cleave.js and bootstrap as yarn packages, also updated the html markup to make use of the bootstrap framework, which gives now a good responsive foundation and fixes the points mentioned in #6