New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integer Overflow && heap-buffer-overflow in kilo.c #60
Comments
|
why my code is: I become a fool!! |
|
Fixed, thanks! |
antirez
added a commit
that referenced
this issue
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a heap overflow caused by integer overflow in kilo.c.
POC:
In command line:
Output:
Analyze:
There is an integer overflow in function editorUpdateRow:
The space size being malloc will be calculated based on the number of TABs in one row.
When the number of TAB is too big,it will lead to Integer Overflow. And it will lead to heap-buffer-overflow finally.
The text was updated successfully, but these errors were encountered: