Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

/api/create_account should return apisecret like /api/login. #110

Merged
merged 1 commit into from Sep 12, 2014

Conversation

Projects
None yet
2 participants
Contributor

beanz commented Nov 14, 2011

An application, such as an android/iphone app, offers a login screen which (like the web equivalent) allows account creation, then after getting the json response from the /api/create_account call it needs to make an additional /api/login call (or some other non-api call I suppose) to get the apisecret. This seems inconsistent and it would be better if the /api/create_account call just returned the apisecret (as well as the auth token that it returns at the moment).

Regards,
Mark.

@zh zh pushed a commit to zh/lamernews that referenced this pull request Dec 7, 2011

stoyan Merge pull request #110 from beanz/create-account-api-secret cd160d5
Collaborator

fcambus commented Jun 20, 2013

Looks great! Could you rebase it atop the current master please?

Contributor

beanz commented Sep 1, 2014

Rebased. Sorry I wasn't paying attention previously. ;-)

Collaborator

fcambus commented Sep 12, 2014

Thanks Mark, merging!

@fcambus fcambus added a commit that referenced this pull request Sep 12, 2014

@fcambus fcambus Merge pull request #110 from beanz/create-account-api-secret
/api/create_account should return apisecret like /api/login.
a45bbb1

@fcambus fcambus merged commit a45bbb1 into antirez:master Sep 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment