Adding an option to open links in a new window #55

Open
wants to merge 7 commits into
from

Projects

None yet

2 participants

@stevenleeg

This has always been a feature that I've looked for in HN. It just adds a simple checkbox to the user's preferences page which allows them to decide whether or not they want links to open in new windows.

@rwaldron rwaldron and 1 other commented on an outdated diff Oct 23, 2011
public/js/app.js
@@ -48,9 +48,12 @@ function submit() {
}
function update_profile() {
+ var checked = '0';
+ if($('input[name=new_window]').is(':checked')) checked = '1';
@rwaldron
rwaldron Oct 23, 2011

You're aware that you've used mis-matched whitespace correct?

Contrary to the rest of the code...

  • You've omitted curly braces
  • You're using a different quote style (single? the rest uses double)
@stevenleeg
stevenleeg Oct 23, 2011

Ah! I hope you'll excuse my newness to contributing to open-source, I didn't even realize things like these mattered. I'll get right on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment