New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support str 8 #44

Merged
merged 1 commit into from Jun 3, 2015

Conversation

Projects
None yet
3 participants
@seppo0010
Contributor

seppo0010 commented May 23, 2015

No description provided.

@seppo0010

This comment has been minimized.

Show comment
Hide comment
Contributor

seppo0010 commented May 23, 2015

@seppo0010

This comment has been minimized.

Show comment
Hide comment
@seppo0010

seppo0010 May 26, 2015

Contributor

msgpack ruby gem was not using str 8 at all up to version 0.5, but since 0.6 it has started to use it. New users will get a failure.

msgpack 0.6:

2.1.2 :004 > MessagePack.pack(' ' * 255)
 => "\xD9\xFF                                                                                                                                                                                                                                                               "

msgpack 0.5.11:

2.1.2 :002 > MessagePack.pack(' ' * 255)
 => "\xDA\x00\xFF                                                                                                                                                                                                                                                               "
Contributor

seppo0010 commented May 26, 2015

msgpack ruby gem was not using str 8 at all up to version 0.5, but since 0.6 it has started to use it. New users will get a failure.

msgpack 0.6:

2.1.2 :004 > MessagePack.pack(' ' * 255)
 => "\xD9\xFF                                                                                                                                                                                                                                                               "

msgpack 0.5.11:

2.1.2 :002 > MessagePack.pack(' ' * 255)
 => "\xDA\x00\xFF                                                                                                                                                                                                                                                               "

slowernet referenced this pull request in soveran/ohm May 26, 2015

@motdotla

This comment has been minimized.

Show comment
Hide comment
@motdotla

motdotla May 31, 2015

I also experienced this problem. Would like to see merged 👍

motdotla commented May 31, 2015

I also experienced this problem. Would like to see merged 👍

antirez added a commit that referenced this pull request Jun 3, 2015

@antirez antirez merged commit dec1810 into antirez:master Jun 3, 2015

@antirez

This comment has been minimized.

Show comment
Hide comment
@antirez

antirez Jun 3, 2015

Owner

Merged. Integrating into Redis right now.

Owner

antirez commented Jun 3, 2015

Merged. Integrating into Redis right now.

@antirez

This comment has been minimized.

Show comment
Hide comment
@antirez

antirez Jun 3, 2015

Owner

p.s. thank you @seppo0010! I'm not sure how I missed this for a so long time, maybe this was added later in the spec.

Owner

antirez commented Jun 3, 2015

p.s. thank you @seppo0010! I'm not sure how I missed this for a so long time, maybe this was added later in the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment