Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Streams API commands #943

Closed
bobby opened this issue Jul 11, 2018 · 6 comments
Closed

Add support for Streams API commands #943

bobby opened this issue Jul 11, 2018 · 6 comments

Comments

@bobby
Copy link
Contributor

bobby commented Jul 11, 2018

It appears that the XGROUP command hasn't yet been added to command reference.

@comnik and I encountered this issue while adding support for Redis Streams to Carmine (cf. taoensso/carmine#208 and taoensso/carmine#210).

@bobby
Copy link
Contributor Author

bobby commented Jul 23, 2018

Bump, @antirez.

@bobby
Copy link
Contributor Author

bobby commented Aug 18, 2018

@antirez Should I open a PR to add this? My team needs this semi-urgently in order to use Streams on our current project.

@tirkarthi
Copy link

I think he is on vacation redis/redis#5203 and communication will be minimal. Feel free to raise a PR.

Thanks

@bobby
Copy link
Contributor Author

bobby commented Aug 27, 2018

@tirkarthi observed that XACK is also missing.

@bobby bobby changed the title Add support for XGROUP command Add support for XGROUP and XACK commands Aug 27, 2018
@tirkarthi
Copy link

Below commands are also missing and thus they are also missing in help @stream. Adding them before release will help since they are used in the redis-cli

  • XCLAIM
  • XDEL
  • XTRIM

Thanks

@bobby bobby changed the title Add support for XGROUP and XACK commands Add support for Streams API commands Aug 28, 2018
@bobby
Copy link
Contributor Author

bobby commented Aug 28, 2018

@tirkarthi @antirez I've added PR #963 to address this issue, but it needs some review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants