New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements of the redis-rb-cluster #6

Open
wants to merge 73 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@iandyh

iandyh commented Oct 19, 2015

These are the main enhancements:

  1. Each redis node has a connection pool(fork safe)
  2. Can enable to read from slave
  3. Each redis command has a corresponding ruby method
  4. Unit tests cover all the commands
  5. Change indention from 4 to 2....

And some other subtle improvements.

Most of the data structure commands are implemented. However, there are still some missing commands, e.g. pubsub and cluster related specific commands.

And the last, what license of this client will be?

This is quite a big PR, thanks!

@iandyh

This comment has been minimized.

iandyh commented Oct 29, 2015

Hi @antirez , will you spend some time on reviewing this PR? Thanks a lot..

@antirez

This comment has been minimized.

Owner

antirez commented Oct 29, 2015

Hello, sorry I have missed this. Sounds interesting! Please could you return the indentation to 4 spaces? This is a matter of tastes and since the project was organized this way it is outside the context of making it better to adapt it to other coding styles ;-) But overall, this is promising and I waited for some improvements, so thanks!

@iandyh

This comment has been minimized.

iandyh commented Oct 29, 2015

@antirez :) I actually prefer 4 spaces since I am from Python world. Sure, will do it soon.

@iandyh

This comment has been minimized.

iandyh commented Oct 30, 2015

@antirez 4 spaces now. :)

@dsklopp

This comment has been minimized.

dsklopp commented Nov 17, 2015

Hello, will this be merged soon? I would like to see the changes iandyh made.

@@ -0,0 +1,1388 @@
#!/usr/bin/env ruby

This comment has been minimized.

@CloudMarc

This comment has been minimized.

@iandyh

iandyh Feb 2, 2016

Yes. But this is only for local development.

@jerryluk

This comment has been minimized.

jerryluk commented May 28, 2016

@antirez Do you think with this PR, this gem would be production ready? We have been waiting long for a stable Ruby client for Redis cluster and I am glad @landyh is able to help.

Thank you for providing such great gem!

@iandyh

This comment has been minimized.

iandyh commented May 30, 2016

@jerryluk Hi! I'd suggest you test this branch in your environment and report any issues back to me.

@mPanasiewicz

This comment has been minimized.

mPanasiewicz commented Jun 16, 2016

Hi,
Will you merge this PR. IS it ok for production enviroment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment