Permalink
Browse files

BITOP bug when called against non existing keys fixed.

In the issue #529 an user reported a bug that can be triggered with the
following code:

flushdb
set a
"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"
bitop or x a b

The bug was introduced with the speed optimization in commit 8bbc076
that specializes every BITOP operation loop up to the minimum length of
the input strings.

However the computation of the minimum length contained an error when a
non existing key was present in the input, after a key that was non zero
length.

This commit fixes the bug and adds a regression test for it.
  • Loading branch information...
1 parent bc70b8e commit 1419406e8dd828f12b4810286d701b2b87ccd7ee @antirez committed May 31, 2012
Showing with 7 additions and 0 deletions.
  1. +1 −0 src/bitops.c
  2. +6 −0 tests/unit/bitops.tcl
View
@@ -197,6 +197,7 @@ void bitopCommand(redisClient *c) {
objects[j] = NULL;
src[j] = NULL;
len[j] = 0;
+ minlen = 0;
continue;
}
/* Return an error if one of the keys is not a string. */
View
@@ -160,4 +160,10 @@ start_server {tags {"bitops"}} {
catch {r bitop xor dest a b c d} e
set e
} {*ERR*}
+
+ test {BITOP with empty string after non empty string (issue #529)} {
+ r flushdb
+ r set a "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"
+ r bitop or x a b
+ } {32}
}

0 comments on commit 1419406

Please sign in to comment.