Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Sentinel test: set less time sensitive defaults.

This commit sets the failover timeout to 30 seconds instead of the 180
seconds default, and allows to reconfigure multiple slaves at the same
time.

This makes tests less sensible to timing, with the result that there are
less false positives due to normal behaviors that require time to
succeed or to be retried.

However the long term solution is probably some way in order to detect
when a test failed because of timing issues (for example split brain
during leader election) and retry it.
  • Loading branch information...
commit 8d011492a0802c45114bab63c41b7311648632be 1 parent 4775099
@antirez authored
Showing with 2 additions and 0 deletions.
  1. +2 −0  tests/sentinel-tests/includes/init-tests.tcl
View
2  tests/sentinel-tests/includes/init-tests.tcl
@@ -30,6 +30,8 @@ test "(init) Sentinels can start monitoring a master" {
foreach_sentinel_id id {
assert {[S $id sentinel master mymaster] ne {}}
S $id SENTINEL SET mymaster down-after-milliseconds 2000
+ S $id SENTINEL SET mymaster failover-timeout 20000
+ S $id SENTINEL SET mymaster parallel-syncs 10
}
}
Please sign in to comment.
Something went wrong with that request. Please try again.