Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Memory leak fixed: release client's bpop->keys dictionary.

Refactoring performed after issue #801 resolution (see commit
2f87cf8) introduced a memory leak that
is fixed by this commit.

I simply forgot to free the new allocated dictionary in the client
structure trusting the output of "make test" on OSX.

However due to changes in the "leaks" utility the test was no longer
testing memory leaks. This problem was also fixed.

Fortunately the CI test running at spotted the bug in the
valgrind run.

The leak never ended into a stable release.
  • Loading branch information...
commit ab2924cff353d7abe293b8f10d032dc466dfd4a4 1 parent a18ca73
@antirez authored
Showing with 1 addition and 0 deletions.
  1. +1 −0  src/networking.c
1  src/networking.c
@@ -605,6 +605,7 @@ void freeClient(redisClient *c) {
c->querybuf = NULL;
if (c->flags & REDIS_BLOCKED)
+ dictRelease(c->bpop.keys);
/* UNWATCH all the keys */

0 comments on commit ab2924c

Please sign in to comment.
Something went wrong with that request. Please try again.