Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

LZF compression re-enabled by default, but with INIT_HTAB set to 0 to…

… avoid the very costly memset initialization. Note that with this option set valgrind will output some false positive about lzf_c.c
  • Loading branch information...
commit b0553789719a3f47531655dab13f5def5ce35403 1 parent 121f70c
@antirez authored
Showing with 6 additions and 6 deletions.
  1. +1 −1  lzfP.h
  2. +1 −1  redis.c
  3. +4 −4 redis.conf
View
2  lzfP.h
@@ -88,7 +88,7 @@
* deterministic/repeatable when the configuration otherwise is the same).
*/
#ifndef INIT_HTAB
-# define INIT_HTAB 1
+# define INIT_HTAB 0
#endif
/*
View
2  redis.c
@@ -1142,7 +1142,7 @@ static void initServerConfig() {
server.appendfilename = "appendonly.aof";
server.requirepass = NULL;
server.shareobjects = 0;
- server.rdbcompression = 0;
+ server.rdbcompression = 1;
server.sharingpoolsize = 1024;
server.maxclients = 0;
server.maxmemory = 0;
View
8 redis.conf
@@ -54,10 +54,10 @@ save 300 10
save 60 10000
# Compress string objects using LZF when dump .rdb databases?
-# For default that's set to 'no' because uses too much CPU time.
-# You want to switch this to 'yes' only if you have a lot of very compressible
-# data inside your dataset and are using replication.
-rdbcompression no
+# For default that's set to 'yes' as it's almost always a win.
+# If you want to save some CPU in the saving child set it to 'no' but
+# the dataset will likely be bigger if you have compressible values or keys.
+rdbcompression yes
# The filename where to dump the DB
dbfilename dump.rdb
Please sign in to comment.
Something went wrong with that request. Please try again.