Permalink
Commits on Feb 11, 2013
  1. Redis 2.6.10

    committed Feb 11, 2013
  2. Tcp keep-alive: send three probes before detectin an error.

    Otherwise we end with less reliable connections because it's too easy
    that a single packet gets lost.
    committed Feb 8, 2013
Commits on Feb 8, 2013
Commits on Feb 7, 2013
Commits on Feb 5, 2013
  1. Turn off TCP_NODELAY on the slave socket after SYNC.

    Further details from @antirez:
    
    It was reported by @StopForumSpam on Twitter that the Redis replication
    link was strangely using multiple TCP packets for multiple commands.
    This wastes a lot of bandwidth and is due to the TCP_NODELAY option we
    enable on the socket after accepting a new connection.
    
    However the master -> slave channel is a one-way channel since Redis
    replication is asynchronous, so there is no point in trying to reduce
    the latency, we should aim to reduce the bandwidth. For this reason this
    commit introduces the ability to disable the nagle algorithm on the
    socket after a successful SYNC.
    
    This feature is off by default because the delay can be up to 40
    milliseconds with normally configured Linux kernels.
    openbaas committed with Jan 31, 2013
  2. Enforce tcl 8.5 or newer

    jbergstroem committed with Jan 23, 2013
  3. Check available tcl versions

    jbergstroem committed with Jan 23, 2013
  4. retval doesn't initalized

    If each if conditions are all fail, variable retval will under uninitlized
    Rock Li committed with Feb 5, 2013
Commits on Feb 4, 2013
  1. Fix a few typos and improve grammar of redis.conf

    Make several edits to the example redis.conf configuration file for
    improved flow and grammar.
    
    Signed-off-by: David Celis <me@davidcel.is>
    davidcelis committed with Feb 3, 2013
  2. Fix a bug in srandmemberWithCountCommand()

    In CASE 2, the call sunionDiffGenericCommand will involve the string "srandmember"
    > sadd foo one
    (integer 1)
    > sadd srandmember two
    (integer 2)
    > srandmember foo 3
    1)"one"
    2)"two"
    ltnwgl committed with Feb 4, 2013
Commits on Jan 23, 2013
  1. Lua struct library updated to version 0.2.

    There was a bug in the previous version of this library that caused a
    crash under the circumstances described in issue #901.
    
    The newer version of the library appears to be fixed (I tested it
    manually with valgrind and everything seems fine now).
    
    For more information about this library please visit this web site:
    
        http://www.inf.puc-rio.br/~roberto/struct/
    committed Jan 23, 2013
Commits on Jan 21, 2013
  1. UNSUBSCRIBE and PUNSUBSCRIBE: always provide a reply.

    UNSUBSCRIBE and PUNSUBSCRIBE commands are designed to mass-unsubscribe
    the client respectively all the channels and patters if called without
    arguments.
    
    However when these functions are called without arguments, but there are
    no channels or patters we are subscribed to, the old behavior was to
    don't reply at all.
    
    This behavior is broken, as every command should always reply.
    Also it is possible that we are no longer subscribed to a channels but we
    are subscribed to patters or the other way around, and the client should
    be notified with the correct number of subscriptions.
    
    Also it is not pretty that sometimes we did not receive a reply at all
    in a redis-cli session from these commands, blocking redis-cli trying
    to read the reply.
    
    This fixes issue #714.
    committed Jan 21, 2013
  2. Fixed a bug in memtest progress bar, that had no actual effects.

    This closes issue #859, thanks to @erbenmo.
    committed Jan 21, 2013
  3. Not every __sun has backtrace().

    I don't know how to test for Open Solaris that has support for
    backtrace() so for now removing the #ifdef that breaks compilation under
    other Solaris flavors.
    committed Jan 21, 2013
Commits on Jan 19, 2013
  1. Whitelist SIGUSR1 to avoid auto-triggering errors.

    This commit fixes issue #875 that was caused by the following events:
    
    1) There is an active child doing BGSAVE.
    2) flushall is called (or any other condition that makes Redis killing
    the saving child process).
    3) An error is sensed by Redis as the child exited with an error (killed
    by a singal), that stops accepting write commands until a BGSAVE happens
    to be executed with success.
    
    Whitelisting SIGUSR1 and making sure Redis always uses this signal in
    order to kill its own children fixes the issue.
    committed Jan 14, 2013
  2. Clear server.shutdown_asap on failed shutdown.

    When a SIGTERM is received Redis schedules a shutdown. However if it
    fails to perform the shutdown it must be clear the shutdown_asap flag
    otehrwise it will try again and again possibly making the server
    unusable.
    committed Jan 19, 2013
  3. Slowlog: don't log EXEC but just the executed commands.

    The Redis Slow Log always used to log the slow commands executed inside
    a MULTI/EXEC block. However also EXEC was logged at the end, which is
    perfectly useless.
    
    Now EXEC is no longer logged and a test was added to test this behavior.
    
    This fixes issue #759.
    committed Jan 19, 2013
  4. Fixed many typos.

    guiquanz committed with Jan 16, 2013
  5. redis-cli prompt bug fix

    openbaas committed with Jan 17, 2013
  6. Always exit if connection fails.

    This avoids unnecessary core dumps. Fixes antirez/redis#894
    badboy committed with Jan 18, 2013
Commits on Jan 18, 2013
  1. redis-cli --rdb fails if server sends a ping

    Redis pings slaves in "pre-synchronization stage" with newlines. (See
    https://github.com/antirez/redis/blob/2.6.9/src/replication.c#L814)
    However, redis-cli does not expect this - it sees the newline as the end
    of the bulk length line, and ends up returning 0 as bulk the length.
    This manifests as the following when running redis-cli:
    
        $ ./src/redis-cli --rdb some_file
        SYNC sent to master, writing 0 bytes to 'some_file'
        Transfer finished with success.
    
    With this commit, we just ignore leading newlines while reading the bulk
    length line.
    
    To reproduce the problem, load enough data into Redis so that the
    preparation of the RDB snapshot takes long enough for a ping to occur
    while redis-cli is waiting for the data.
    nparry committed with Jan 18, 2013
Commits on Jan 16, 2013
  1. Redis 2.6.9

    committed Jan 16, 2013