Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Mar 11, 2013
  1. Redis 2.6.11

    authored
  2. activeExpireCycle() smarter with many DBs and under expire pressure.

    authored
    activeExpireCycle() tries to test just a few DBs per iteration so that
    it scales if there are many configured DBs in the Redis instance.
    However this commit makes it a bit smarter when one a few of those DBs
    are under expiration pressure and there are many many keys to expire.
    
    What we do is to remember if in the last iteration had to return because
    we ran out of time. In that case the next iteration we'll test all the
    configured DBs so that we are sure we'll test again the DB under
    pressure.
    
    Before of this commit after some mass-expire in a given DB the function
    tested just a few of the next DBs, possibly empty, a few per iteration,
    so it took a long time for the function to reach again the DB under
    pressure. This resulted in a lot of memory being used by already expired
    keys and never accessed by clients.
  3. activeExpireCycle(): process only a small number of DBs per iteration.

    authored
    This small number of DBs is set to 16 so actually in the default
    configuraiton Redis should behave exactly like in the past.
    However the difference is that when the user configures a very large
    number of DBs we don't do an O(N) operation, consuming a non trivial
    amount of CPU per serverCron() iteration.
  4. Only resize/rehash a few databases per cron iteration.

    authored
    This is the first step to lower the CPU usage when many databases are
    configured. The other is to also process a limited number of DBs per
    call in the active expire cycle.
  5. serverCron() frequency is now a runtime parameter (was REDIS_HZ).

    authored
    REDIS_HZ is the frequency our serverCron() function is called with.
    A more frequent call to this function results into less latency when the
    server is trying to handle very expansive background operations like
    mass expires of a lot of keys at the same time.
    
    Redis 2.4 used to have an HZ of 10. This was good enough with almost
    every setup, but the incremental key expiration algorithm was working a
    bit better under *extreme* pressure when HZ was set to 100 for Redis
    2.6.
    
    However for most users a latency spike of 30 milliseconds when million
    of keys are expiring at the same time is acceptable, on the other hand a
    default HZ of 100 in Redis 2.6 was causing idle instances to use some
    CPU time compared to Redis 2.4. The CPU usage was in the order of 0.3%
    for an idle instance, however this is a shame as more energy is consumed
    by the server, if not important resources.
    
    This commit introduces HZ as a runtime parameter, that can be queried by
    INFO or CONFIG GET, and can be modified with CONFIG SET. At the same
    time the default frequency is set back to 10.
    
    In this way we default to a sane value of 10, but allows users to
    easily switch to values up to 500 for near real-time applications if
    needed and if they are willing to pay this small CPU usage penalty.
Commits on Mar 6, 2013
  1. @ltnwgl

    Removed useless "return" statements in pubsub.c

    ltnwgl authored committed
    (original commit message edited)
  2. API to lookup commands with their original name.

    authored
    A new server.orig_commands table was added to the server structure, this
    contains a copy of the commant table unaffected by rename-command
    statements in redis.conf.
    
    A new API lookupCommandOrOriginal() was added that checks both tables,
    new first, old later, so that rewriteClientCommandVector() and friends
    can lookup commands with their new or original name in order to fix the
    client->cmd pointer when the argument vector is renamed.
    
    This fixes the segfault of issue #986, but does not fix a wider range of
    problems resulting from renaming commands that actually operate on data
    and are registered into the AOF file or propagated to slaves... That is
    command renaming should be handled with care.
  3. Handle a non-impossible empty argv in loadServerConfigFromString().

    authored
    Usually this does not happens since we trim for " \t\r\n", but if there
    are other chars that return true with isspace(), we may end with an
    empty argv. Better to handle the condition in an explicit way.
  4. sdssplitargs(): on error set *argc to 0.

    authored
    This makes programs not checking the return value for NULL much safer
    since with this change:
    
    1) It is still possible to iterate the zero-length result without
    crashes.
    2) sdssplitargs_free will work against NULL and 0 count.
  5. sdssplitargs(): now returns NULL only on error.

    authored
    An empty input string also resulted into the function returning NULL
    making it harder for the caller to distinguish between error and empty
    string without checking the original input string length.
  6. @openbaas

    Don't segfault on unbalanced quotes.

    openbaas authored committed
  7. Allow AUTH while loading the DB in memory.

    authored
    While Redis is loading the AOF or RDB file in memory only a subset of
    commands are allowed. This commit adds AUTH to this subset.
Commits on Mar 4, 2013
  1. redis-cli: use keepalive socket option.

    authored
    This should improve things in two ways:
    
    1) Prevent timeouts caused by the execution of long commands.
    2) Improve detection of real connection errors.
    
    This is mostly effective only on Linux because of the bogus default
    keepalive settings. In Linux we have OS-specific calls to set the
    keepalive interval to reasonable values.
  2. @0x20h

    suppress external diff program when using git diff.

    0x20h authored committed
  3. @stamhe

    add a check for aeCreateTimeEvent

    stamhe authored committed
    1) Add a check for aeCreateTimeEvent in function initServer.
  4. @stamhe
Commits on Feb 12, 2013
  1. @svnpenn

    Format to fit 80 columns

    svnpenn authored committed
    This makes it readable on GitHub and editors without auto wrapping.
Commits on Feb 11, 2013
  1. Redis 2.6.10

    authored
  2. Tcp keep-alive: send three probes before detectin an error.

    authored
    Otherwise we end with less reliable connections because it's too easy
    that a single packet gets lost.
Something went wrong with that request. Please try again.