Permalink
Commits on Nov 8, 2012
  1. Redis 2.6.4

    committed Nov 8, 2012
  2. Make clear that contributing code to the Redis project means to relea…

    …se it under the terms of the BSD license.
    committed Nov 8, 2012
Commits on Nov 6, 2012
  1. Redis 2.6.3

    committed Nov 6, 2012
Commits on Nov 2, 2012
  1. fix a typo in redis.h line 595 comment

    run committed with Oct 31, 2012
Commits on Nov 1, 2012
  1. More robust handling of AOF rewrite child.

    After the wait3() syscall we used to do something like that:
    
        if (pid == server.rdb_child_pid) {
            backgroundSaveDoneHandler(exitcode,bysignal);
        } else {
            ....
        }
    
    So the AOF rewrite was handled in the else branch without actually
    checking if the pid really matches. This commit makes the check explicit
    and logs at WARNING level if the pid returned by wait3() does not match
    neither the RDB or AOF rewrite child.
    committed Nov 1, 2012
  2. Merge pull request #743 from Cofyc/fixtypo

    fix typo in comments (redis.c, networking.c)
    committed Nov 1, 2012
  3. Unix socket clients properly displayed in MONITOR and CLIENT LIST.

    This also fixes issue #745.
    committed Nov 1, 2012
  4. 32 bit build fixed on Linux.

    It failed because of the way jemalloc was compiled (without passing the
    right flags to make, but just to configure). Now the same set of flags
    are also passed to the make command, fixing the issue.
    
    This fixes issue #744
    committed Nov 1, 2012
Commits on Oct 31, 2012
  1. fix a typo in a comment

    yamt committed with Oct 24, 2012
  2. Invert two sides of if expression in SET to avoid a lookup.

    Because of the short circuit behavior of && inverting the two sides of
    the if expression avoids an hash table lookup if the non-EX variant of
    SET is called.
    
    Thanks to Weibin Yao (@yaoweibin on github) for spotting this.
    committed Oct 31, 2012
Commits on Oct 30, 2012
Commits on Oct 26, 2012
  1. Redis 2.6.2

    committed Oct 26, 2012
  2. Ctrl+w support in linenoise.

    committed Oct 26, 2012
Commits on Oct 25, 2012
  1. Redis 2.6.1

    committed Oct 25, 2012
  2. Fix compilation on Linux kernels or glibc versions lacking sync_file_…

    …range().
    
    This fixes issue #667.
    
    Many thanks to Didier Spezia for the fix.
    committed Oct 25, 2012
Commits on Oct 24, 2012
Commits on Oct 22, 2012
  1. Redis 2.6.0

    committed Oct 22, 2012
  2. A filed called slave_read_only added in INFO output.

    This was an important information missing from the INFO output in the
    replication section.
    
    It obviously reflects if the slave is read only or not.
    committed Oct 22, 2012
  3. Fix (cosmetic) typos in dict.h

    Greg Hurrell committed with Oct 3, 2012
  4. redis-check-dump now understands dumps produced by Redis 2.6

    (Commit message from @antirez as it was missign in the original commits,
    also the patch was modified a bit to still work with 2.4 dumps and to
    avoid if expressions that are always true due to checked types range)
    
    This commit changes redis-check-dump to account for new encodings and
    for the new MSTIME expire format. It also refactors the test for valid
    type into a function.
    
    The code is still compatible with Redis 2.4 generated dumps.
    
    This fixes issue #709.
    ripcurld00d committed with Oct 22, 2012
  5. Default memory limit for 32bit instanced moved from 3.5 GB to 3 GB.

    In some system, notably osx, the 3.5 GB limit was too far and not able
    to prevent a crash for out of memory. The 3 GB limit works better and it
    is still a lot of memory within a 4 GB theorical limit so it's not going
    to bore anyone :-)
    
    This fixes issue #711
    committed Oct 22, 2012
  6. Differentiate SCRIPT KILL error replies.

    When calling SCRIPT KILL currently you can get two errors:
    
    * No script in timeout (busy) state.
    * The script already performed a write.
    
    It is useful to be able to distinguish the two errors, but right now both
    start with "ERR" prefix, so string matching (that is fragile) must be used.
    
    This commit introduces two different prefixes.
    
    -NOTBUSY and -UNKILLABLE respectively to reply with an error when no
    script is busy at the moment, and when the script already executed a
    write operation and can not be killed.
    committed Oct 22, 2012
Commits on Oct 18, 2012
  1. Update src/redis-benchmark.c

    The code of current implementation:
    
    if (c->pending == 0) clientDone(c);
    In clientDone function, the c's memory has been freed, then the loop will continue: while(c->pending). The memory of c has been freed now, so c->pending is invalid (c is an invalid pointer now), and this will cause memory dump in some platforams(eg: Solaris).
    
    So I think the code should be modified as:
    if (c->pending == 0)
    {
    clientDone(c);
    break;
    }
    and this will not lead to while(c->pending).
    NanXiao committed with Oct 10, 2012
Commits on Oct 16, 2012
  1. Fix MULTI / EXEC rendering in MONITOR output.

    Before of this commit it used to be like this:
    
    MULTI
    EXEC
    ... actual commands of the transaction ...
    
    Because after all that is the natural order of things. Transaction
    commands are queued and executed *only after* EXEC is called.
    
    However this makes debugging with MONITOR a mess, so the code was
    modified to provide a coherent output.
    
    What happens is that MULTI is rendered in the MONITOR output as far as
    possible, instead EXEC is propagated only after the transaction is
    executed, or even in the case it fails because of WATCH, so in this case
    you'll simply see:
    
    MULTI
    EXEC
    
    An empty transaction.
    committed Oct 16, 2012
Commits on Oct 11, 2012
  1. Allow AUTH when Redis is busy because of timedout Lua script.

    If the server is password protected we need to accept AUTH when there is
    a server busy (-BUSY) condition, otherwise it will be impossible to send
    SHUTDOWN NOSAVE or SCRIPT KILL.
    
    This fixes issue #708.
    committed Oct 11, 2012
Commits on Oct 6, 2012
  1. CONTRIBUTING file updated.

    committed Oct 6, 2012
Commits on Oct 5, 2012
  1. Redis 2.6.0 RC8 (2.5.14)

    committed Oct 5, 2012
  2. Merge pull request #544 from dvirsky/2.6

    fixed install script to rewrite the default config
    committed Oct 5, 2012
  3. Hash function switched to murmurhash2.

    The previously used hash function, djbhash, is not secure against
    collision attacks even when the seed is randomized as there are simple
    ways to find seed-independent collisions.
    
    The new hash function appears to be safe (or much harder to exploit at
    least) in this case, and has better distribution.
    
    Better distribution does not always means that's better. For instance in
    a fast benchmark with "DEBUG POPULATE 1000000" I obtained the following
    results:
    
        1.6 seconds with djbhash
        2.0 seconds with murmurhash2
    
    This is due to the fact that djbhash will hash objects that follow the
    pattern `prefix:<id>` and where the id is numerically near, to near
    buckets. This improves the locality.
    
    However in other access patterns with keys that have no relation
    murmurhash2 has some (apparently minimal) speed advantage.
    
    On the other hand a better distribution should significantly
    improve the quality of the distribution of elements returned with
    dictGetRandomKey() that is used in SPOP, SRANDMEMBER, RANDOMKEY, and
    other commands.
    
    Everything considered, and under the suspect that this commit fixes a
    security issue in Redis, we are switching to the new hash function.
    If some serious speed regression will be found in the future we'll be able
    to step back easiliy.
    
    This commit fixes issue #663.
    committed Oct 3, 2012