Permalink
Commits on Aug 28, 2012
  1. Sentinel: Sentinel-side support for slave priority.

    antirez committed Aug 28, 2012
    The slave priority that is now published by Redis in INFO output is
    now used by Sentinel in order to select the slave with minimum priority
    for promotion, and in order to consider slaves with priority set to 0 as
    not able to play the role of master (they will never be promoted by
    Sentinel).
    
    The "slave-priority" field is now one of the fileds that Sentinel
    publishes when describing an instance via the SENTINEL commands such as
    "SENTINEL slaves mastername".
  2. Sentinel: Redis-side support for slave priority.

    antirez committed Aug 28, 2012
    A Redis slave can now be configured with a priority, that is an integer
    number that is shown in INFO output and can be get and set using the
    redis.conf file or the CONFIG GET/SET command.
    
    This field is used by Sentinel during slave election. A slave with lower
    priority is preferred. A slave with priority zero is never elected (and
    is considered to be impossible to elect even if it is the only slave
    available).
    
    A next commit will add support in the Sentinel side as well.
  3. Sentinel: suppress harmless warning by initializing 'table' to NULL.

    antirez committed Aug 28, 2012
    Note that the assertion guarantees that one of the if branches setting
    table is always entered.
  4. Incrementally flush RDB on disk while loading it from a master.

    antirez committed Aug 24, 2012
    This fixes issue #539.
    
    Basically if there is enough free memory the OS may buffer the RDB file
    that the slave transfers on disk from the master. The file may
    actually be flused on disk at once by the operating system when it gets
    closed by Redis, causing the close system call to block for a long time.
    
    This patch is a modified version of one provided by yoav-steinberg of
    @garantiadata (the original version was posted in the issue #539
    comments), and tries to flush the OS buffers incrementally (every 8 MB
    of loaded data).
Commits on Aug 24, 2012
  1. Better Out of Memory handling.

    antirez committed Aug 24, 2012
    The previous implementation of zmalloc.c was not able to handle out of
    memory in an application-specific way. It just logged an error on
    standard error, and aborted.
    
    The result was that in the case of an actual out of memory in Redis
    where malloc returned NULL (In Linux this actually happens under
    specific overcommit policy settings and/or with no or little swap
    configured) the error was not properly logged in the Redis log.
    
    This commit fixes this problem, fixing issue #509.
    Now the out of memory is properly reported in the Redis log and a stack
    trace is generated.
    
    The approach used is to provide a configurable out of memory handler
    to zmalloc (otherwise the default one logging the event on the
    standard output is used).
  2. Sentinel: send SCRIPT KILL on -BUSY reply and SDOWN instance.

    antirez committed Aug 24, 2012
    From the point of view of Redis an instance replying -BUSY is down,
    since it is effectively not able to reply to user requests. However
    a looping script is a recoverable condition in Redis if the script still
    did not performed any write to the dataset. In that case performing a
    fail over is not optimal, so Sentinel now tries to restore the normal server
    condition killing the script with a SCRIPT KILL command.
    
    If the script already performed some write before entering an infinite
    (or long enough to timeout) loop, SCRIPT KILL will not work and the
    fail over will be triggered anyway.
  3. Sentinel: fixed a crash on script execution.

    antirez committed Aug 24, 2012
    The call to sentinelScheduleScriptExecution() lacked the final NULL
    argument to signal the end of arguments. This resulted into a crash.
Commits on Aug 22, 2012
  1. Merge pull request #628 from pietern/unstable-zip

    antirez committed Aug 22, 2012
    Fix ziplist edge case
Commits on Aug 21, 2012
  1. redis-benchmark: disable big buffer cleanup in hiredis context.

    antirez committed Aug 21, 2012
    This new hiredis features allows us to reuse a previous context reader
    buffer even if already very big in order to maximize performances with
    big payloads (Usually hiredis re-creates buffers when they are too big
    and unused in order to save memory).
  2. hiredis library updated.

    antirez committed Aug 21, 2012
    This version of hiredis merges modifications of the Redis fork with
    latest changes in the hiredis repository.
    
    The same version was pushed on the hiredis repository and will probably
    merged into the master branch in short time.
Commits on Aug 13, 2012
Commits on Aug 3, 2012
  1. Sentinel: SENTINEL FAILOVER command implemented.

    antirez committed Aug 3, 2012
    This command can be used in order to force a Sentinel instance to start
    a failover for the specified master, as leader, forcing the failover
    even if the master is up.
    
    The commit also adds some minor refactoring and other improvements to
    functions already implemented that make them able to work when the
    master is not in SDOWN condition. For instance slave selection
    assumed that we ask INFO every second to every slave, this is true
    only when the master is in SDOWN condition, so slave selection did not
    worked when the master was not in SDOWN condition.
Commits on Aug 2, 2012
  1. Sentinel: client reconfiguration script execution.

    antirez committed Aug 2, 2012
    This commit adds support to optionally execute a script when one of the
    following events happen:
    
    * The failover starts (with a slave already promoted).
    * The failover ends.
    * The failover is aborted.
    
    The script is called with enough parameters (documented in the example
    sentinel.conf file) to provide information about the old and new ip:port
    pair of the master, the role of the sentinel (leader or observer) and
    the name of the master.
    
    The goal of the script is to inform clients of the configuration change
    in a way specific to the environment Sentinel is running, that can't be
    implemented in a genereal way inside Sentinel itself.
  2. Merge pull request #613 from tobstarr/patch-1

    antirez committed Aug 2, 2012
    Fix version numbers
  3. Fix version numbers

    tobstarr committed Aug 2, 2012
Commits on Jul 31, 2012
  1. Sentinel: when leader in wait-start, sense another leader as race.

    antirez committed Jul 31, 2012
    When we are in wait start, if another leader (or any other external
    entity) turns a slave into a master, abort the failover, and detect it
    as an observer.
    
    Note that the wait-start state is mainly there for this reason but the
    abort was yet not implemented.
    
    This adds a new sentinel event -failover-abort-race.
  2. Use correct variable name for value to convert.

    mgp committed with antirez Jul 26, 2012
    Note by @antirez: this code was never compiled because utils.c lacked the
    float.h include, so we never noticed this variable was mispelled in the
    past.
    
    This should provide a noticeable speed boost when saving certain types
    of databases with many sorted sets inside.
  3. Sentinel: abort failover when in wait-start if master is back.

    antirez committed Jul 31, 2012
    When we are a Leader Sentinel in wait-start state, starting with this
    commit the failover is aborted if the master returns online.
    
    This improves the way we handle a notable case of net split, that is the
    split between Sentinels and Redis servers, that will be a very common
    case of split becase Sentinels will often be installed in the client's
    network and servers can be in a differnt arm of the network.
    
    When Sentinels and Redis servers are isolated the master is in ODOWN
    condition since the Sentinels can agree about this state, however the
    failover does not start since there are no good slaves to promote (in
    this specific case all the slaves are unreachable).
    
    However when the split is resolved, Sentinels may sense the slave back
    a moment before they sense the master is back, so the failover may start
    without a good reason (since the master is actually working too).
    
    Now this condition is reversible, so the failover will be aborted
    immediately after if the master is detected to be working again, that
    is, not in SDOWN nor in ODOWN condition.
Commits on Jul 28, 2012
  1. Sentinel: scripts execution engine improved.

    antirez committed Jul 27, 2012
    We no longer use a vanilla fork+execve but take a queue of jobs of
    scripts to execute, with retry on error, timeouts, and so forth.
    
    Currently this is used only for notifications but soon the ability to
    also call clients reconfiguration scripts will be added.
  2. comment fix

    jzawodn committed with antirez Jul 25, 2012
    improve English a bit. :-)
  3. Merge pull request #606 from badboy/patch-1

    antirez committed Jul 28, 2012
    Include sys/wait.h to avoid compiler warning
  4. Include sys/wait.h to avoid compiler warning

    badboy committed Jul 28, 2012
    gcc warned about an implicit declaration of function 'wait3'. 
    Including this header fixes this.
Commits on Jul 27, 2012
  1. Merge pull request #587 from saj/truncate-short-write-from-aof

    antirez committed Jul 27, 2012
    Truncate short write from the AOF
  2. Merge pull request #586 from saj/aof_last_bgrewrite_status

    antirez committed Jul 27, 2012
    New in INFO: aof_last_bgrewrite_status
Commits on Jul 26, 2012
Commits on Jul 25, 2012
  1. Merge pull request #604 from jzawodn/patch-1

    antirez committed Jul 25, 2012
    comment fix
  2. comment fix

    jzawodn committed Jul 25, 2012
    improve English a bit. :-)
  3. Merge pull request #603 from mrb/fix_sentinel_config_warning

    antirez committed Jul 25, 2012
    Fix warning in redis.c for sentinel config load