Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Redis crashes on double 'KEYS *' #1208

Closed
badboy opened this Issue · 4 comments

3 participants

@badboy

(This was tested against the dump.rdb of ty.redis.io)

894eba0, a316934 and 7ed7652 all crashed, crash dump log here: https://gist.github.com/badboy/6054491
I can provide the dump.rdb and core files if needed.

[17034] 22 Jul 16:58:09.893 # === ASSERTION FAILED ===
[17034] 22 Jul 16:58:09.893 # ==> networking.c:1470 'c->reply_bytes < ULONG_MAX-(1024*64)' is not true

What I did:

127.0.0.1:6379> keys *
1) "loooooooooooongkey:4"
[…]
74180) "anotherlooooooooongkey:5"
74181) "yetanotherkeyinhere:server:name"
(1.29s)
127.0.0.1:6379> keys *
Could not connect to Redis at 127.0.0.1:6379: Connection refused
(0.70s)
not connected>
@antirez
Owner

Thanks \o/ !!

Please could you send me the RDB file?

@badboy

Mail sent.

@antirez
Owner

Thanks, I can reproduce it (only on Linux strange enough). Working on it ASAP.

@antirez antirez referenced this issue from a commit
@antirez Fix setDeferredMultiBulkLength() c->reply_bytes handling with EMBSTR
This function missed proper handling of reply_bytes when gluing to the
previous object was used. The issue was introduced with the EMBSTR new
string object encoding.

This fixes issue #1208.
dbaa5b0
@mattsta

Fixed in dbaa5b0

@mattsta mattsta closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.