New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why markNodeAsFailingIfNeeded function always failures++ #2622

Closed

chang290 opened this issue Jun 15, 2015 · 1 comment

chang290 commented Jun 15, 2015

cluster.c

Author

chang290 commented Jun 15, 2015

line 1156
if (nodeIsMaster(myself)) failures++;
why if master,need failures++;
why not check local this node's flag == PFAIL like this;

if (nodeIsMaster(myself) && (node->flags & REDIS_NODE_PFAIL)) failures++;

chang290 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment